This repository was archived by the owner on Feb 19, 2025. It is now read-only.
issue #126 - don't crash on uninitialized properties#655
Open
pounard wants to merge 1 commit intoOcramius:4.6.xfrom
Open
issue #126 - don't crash on uninitialized properties#655pounard wants to merge 1 commit intoOcramius:4.6.xfrom
pounard wants to merge 1 commit intoOcramius:4.6.xfrom
Conversation
10421dc to
ce635e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the liberty of creating a duplicate of #370 that fixes #126.
I have copy/pasted code from the former, but changed the way the guard is implemented by simply writing the extract this way:
Hiding engine errors is probably a terrible thing to do, although it works.
There is a question remaining open, should we instead write this ?
I guess simply not setting the value in the array is more representative of what is happening: the value don't get set in the array since it wasn't set at all in the object. I don't care which is the best, both will work for most my use cases, or can be worked around easily.