fix update command

[Germandrummer92]

version before update: packages@ /Users/ddraper/.local/packages
└── @octomind/octomind@4.2.0


✔ update complete: packages@ /Users/ddraper/.local/packages
└── @octomind/octomind@4.3.0

Greptile Summary

Fixed path construction in the update command from path.join(homedir(), "/.local/packages") to path.join(homedir(), ".local", "packages") and added version display before and after the update operation.

• Corrected improper path construction that mixed absolute path syntax with path.join
• Added version checking using npm list @octomind/octomind before and after update
• Silenced npm install output with stdio: "ignore" for cleaner console output
• Fixed cwd parameter for npm install to use pathToRoot instead of its parent directory
• Test file has a critical bug: path construction doesn't match the implementation, which will cause test failures

Confidence Score: 2/5

• This PR has a critical test bug that causes path mismatch between implementation and tests
• The implementation changes look good, but the test file contains a logical error where the path construction still uses the old format, which doesn't match the updated implementation and will likely cause test failures
• Pay close attention to tests/tools/update.spec.ts - the path construction must be fixed to match the implementation

Important Files Changed

Filename	Overview
src/tools/update.ts	Fixed path construction and added version display before/after update
tests/tools/update.spec.ts	Updated cwd parameter but path construction still mismatched, missing new version check assertions

Sequence Diagram

sequenceDiagram
    participant User
    participant UpdateFunc as update()
    participant FS as File System
    participant NPM as npm

    User->>UpdateFunc: Call update()
    UpdateFunc->>UpdateFunc: Build path to ~/.local/packages
    UpdateFunc->>FS: Check package.json exists
    alt package.json not found
        FS-->>UpdateFunc: Not found
        UpdateFunc->>User: Exit with error
    end
    
    UpdateFunc->>NPM: Check npm available
    alt npm not found
        NPM-->>UpdateFunc: Not found
        UpdateFunc->>User: Exit with error
    end
    
    UpdateFunc->>NPM: npm list @octomind/octomind
    NPM-->>UpdateFunc: Old version info
    UpdateFunc->>User: Display version before update
    
    UpdateFunc->>NPM: npm install @octomind/octomind@latest
    NPM-->>UpdateFunc: Installation complete
    
    UpdateFunc->>NPM: npm list @octomind/octomind
    NPM-->>UpdateFunc: New version info
    UpdateFunc->>User: Display update complete with new version

Loading

[greptile-apps]

Additional Comments (2)

1. tests/tools/update.spec.ts, line 16-18 (link)

   logic: path construction doesn't match the implementation in update.ts:10 which uses path.join(homedir(), ".local", "packages")

2. tests/tools/update.spec.ts, line 33-40 (link)

   style: verify the new npm list @octomind/octomind calls are tested (lines 28, 40 in update.ts)

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}