Adopting PrettyGCode plugin#1459
Merged
Merged
Conversation
Member
Author
|
To make the review easier: previous maintainer/repo references within the plugin code have been replaced by this commit |
Member
Author
|
Thanks for merging Jim! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've finally completed the work needed to adopt the PrettyGCode plugin.
As shown in the changelog of release 2.0.0, this involved 20 very intensive days of work, which included a massive refactor and the fix of numerous bugs. Overall it amounts to a difference of +10k -9k lines of code, but I'm finally satisfied with the new state of the frontend code, which I now find particularly robust and readable.
This adoption request closes the long-standing #1342 (close #1342).