Skip to content

fix: Remove "The slug {Slug} did not match any of your Octopus Feature Toggles" log message when evaluating a toggle #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
borland wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Remove "The slug {Slug} did not match any of your Octopus Feature Toggles" log message when evaluating a toggle #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/Octopus.OpenFeature.Provider.Tests/OctopusFeatureContextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,29 +425,5 @@ public void GetNormalizedNumber_MatchesExpectedValue(string evaluationKey, strin
{
OctopusFeatureContext.GetNormalizedNumber(evaluationKey, targetingKey).Should().Be(expected);
}

[Fact]
public void WhenSameMissingSlug_IsEvaluatedRepeatedly_OnlyOneWarningIsLogged()
{
var featureToggles = new FeatureToggles([
new FeatureToggleEvaluation("known-feature", true, "evaluation-key", [], 100)
], []);
var fakeLogger = new FakeLogger();
var context = new OctopusFeatureContext(featureToggles, new SingleLoggerFactory(fakeLogger));

for (var i = 0; i < 10; i++)
{
context.Evaluate("missing-slug", defaultValue: false, context: null);
}

fakeLogger.Collector.GetSnapshot().Should().ContainSingle(r => r.Level == LogLevel.Warning);
}

class SingleLoggerFactory(ILogger logger) : ILoggerFactory
{
public ILogger CreateLogger(string categoryName) => logger;
public void AddProvider(ILoggerProvider provider) { }
public void Dispose() { }
}
}

9 changes: 0 additions & 9 deletions src/Octopus.OpenFeature.Provider/OctopusFeatureContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,9 @@

namespace Octopus.OpenFeature.Provider;

partial class OctopusFeatureContext(FeatureToggles toggles, ILoggerFactory loggerFactory)

Check warning on line 11 in src/Octopus.OpenFeature.Provider/OctopusFeatureContext.cs

View workflow job for this annotation

GitHub Actions / test-build-and-publish 

Parameter 'loggerFactory' is unread.

Check warning on line 11 in src/Octopus.OpenFeature.Provider/OctopusFeatureContext.cs

View workflow job for this annotation

GitHub Actions / test-build-and-publish 

Parameter 'loggerFactory' is unread.
{
public byte[] ContentHash => toggles.ContentHash;
readonly ILogger logger = loggerFactory.CreateLogger<OctopusFeatureContext>();
readonly ConcurrentDictionary<string, byte> warnedSlugs = new(StringComparer.OrdinalIgnoreCase);

public static OctopusFeatureContext Empty(ILoggerFactory loggerFactory)
{
Expand All @@ -30,13 +28,6 @@

if (feature == null)
{
if (warnedSlugs.TryAdd(slug, 0))
{
logger.LogWarning(
"The slug {Slug} did not match any of your Octopus Feature Toggles. Please double check your slug and try again.",
slug);
}

return new ResolutionDetails<bool>(slug, defaultValue, ErrorType.FlagNotFound,
"The slug provided did not match any of your Octopus Feature Toggles. Please double check your slug and try again.");
}
Expand Down
Loading