add attestationGloas and replace usages - #17258
Open
Inspector-Butters wants to merge 2 commits into
Open
Conversation
Inspector-Butters
force-pushed
the
add-attestation-gloas
branch
2 times, most recently
from
July 29, 2026 10:36
2d84c8c to
ab8c22c
Compare
Inspector-Butters
force-pushed
the
add-attestation-gloas
branch
from
July 29, 2026 10:37
ab8c22c to
18909e8
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
syjn99
self-requested a review
July 29, 2026 11:09
syjn99
reviewed
Jul 29, 2026
| repeated AttesterSlashingElectra attester_slashings = 5 | ||
| [ (ethereum.eth.ext.ssz_max) = "1" ]; | ||
| repeated AttestationElectra attestations = 6 | ||
| repeated AttestationGloas attestations = 6 |
Member
There was a problem hiding this comment.
So we might search the entire codebase that can be broken with this change. One concern is the parts that we "assert" some variable as AttestationElectra type like:
prysm/beacon-chain/rpc/eth/beacon/handlers.go
Line 297 in 549197f
|
|
||
| // Version -- | ||
| func (a *AttestationGloas) Version() int { | ||
| return version.Gloas |
Member
There was a problem hiding this comment.
Suggested change
| return version.Gloas | |
| return version.Electra |
Yeah this looks weird but I believe this should be
Member
There was a problem hiding this comment.
OR finding all att.Version() parts and checks whether the predicate contains equal sign/inequality sign, that is either
if att.Version() == version.Electra: This can be problematic with the change that this PR bringsif att.Version() >= version.Electra: This is OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
AttestationGloasand replace usages throughout the codebase, in order for codegen to be able to distinguish between the progressive and legacy merkleization.