added isAnonymousAccessAllowed to devPreview#150
Open
charlesji-msft-teams wants to merge 1 commit intoOfficeDev:preview/DevPreviewfrom
Open
added isAnonymousAccessAllowed to devPreview#150charlesji-msft-teams wants to merge 1 commit intoOfficeDev:preview/DevPreviewfrom
charlesji-msft-teams wants to merge 1 commit intoOfficeDev:preview/DevPreviewfrom
Conversation
ht4963-ms
reviewed
Oct 13, 2022
| }, | ||
| "isAnonymousAccessAllowed": { | ||
| "type": "boolean", | ||
| "description": "A boolean value indicating whether this app allows management by anonymous users.", |
There was a problem hiding this comment.
"management" or "access"? I think the description may be a bit misleading.
Member
There was a problem hiding this comment.
Lets just align the description with that of the new property that will supersede it anyways.
"A boolean value indicating whether this app supports access by anonymous guest users."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.