Restrict XLL filename to non-whitespace characters using JavaScript-compatible regex#193
Open
krisztianjofoldi wants to merge 1 commit intoOfficeDev:mainfrom
Open
Restrict XLL filename to non-whitespace characters using JavaScript-compatible regex#193krisztianjofoldi wants to merge 1 commit intoOfficeDev:mainfrom
krisztianjofoldi wants to merge 1 commit intoOfficeDev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the extensionXllCustomFunctions.fileName property validation regex in the schema to use a simpler, JavaScript-compatible pattern: ^[^\\s]*\.xll$. This ensures that XLL filenames cannot contain any whitespace characters, and improves compatibility with JavaScript libraries. The previous pattern has been replaced to avoid unsupported control character escapes and simplify validation logic.