Skip to content

[IMP] add match details in event template to support updating match events#169

Open
Bart274 wants to merge 1 commit into
Olen:mainfrom
Bart274:matches
Open

[IMP] add match details in event template to support updating match events#169
Bart274 wants to merge 1 commit into
Olen:mainfrom
Bart274:matches

Conversation

@Bart274
Copy link
Copy Markdown

@Bart274 Bart274 commented Dec 29, 2024

Should help #112

@Olen
Copy link
Copy Markdown
Owner

Olen commented Dec 29, 2024

What happens if the event is not a match? Will something break when submitting an event with match data?
I think there needs to be some checks for that.

@Olen
Copy link
Copy Markdown
Owner

Olen commented May 14, 2026

@Bart274 friendly ping — pulling together a 1.2.1 release sweep and would like to include this if we can resolve the open question. Quoting the original concern from late 2024:

What happens if the event is not a match? Will something break when submitting an event with match data?

The added matchEvent: False default plus the nested matchInfo (all None) is what worries me — for a non-match event (e.g. training), do those fields get rejected by the API, silently ignored, or accepted as-is? A quick update_event against a real training event with the new template would settle it.

Happy to merge once we have that confirmation (or a small conditional that only includes matchInfo when matchEvent=True).

@Olen Olen mentioned this pull request May 14, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants