fix: fetch single event by uid directly (#137, #138)

[Olen]

Summary

Closes #137 and #138 with a single root-cause fix.

get_event(uid) previously routed through _get_entity(), which fetched a list via get_events() (with no args) and searched it. That list inherits get_events()'s defaults:

• max_events=100 → events past the 100th are unreachable (Spond.get_event() may not return an event if more than 100 events are available #137)
• include_scheduled=False → scheduled events are unreachable (Spond.get_event() doesn't return 'scheduled' events, i.e. where invites are set to send in the future. #138)

Switch _get_entity() for events to fetch from the singular sponds/{uid}?includeComments=true endpoint directly. Neither limit applies. Group lookups stay on the cache+search path — they don't have these defaults.

Live verification against the Spond API

Probed the endpoint before coding (and re-verified the fixed code) using credentials from ../spond-kalender:

[real id]                     status=200  ok=True   → event JSON dict
[real id + includeComments]   status=200  ok=True   → adds `comments` field
[bogus id]                    status=404  ok=False  → {"message":"sponds/...","errorCode":404}

OK: get_event returned id=455D0EEA..., heading='Fotballtrening 9-er'
OK: bogus id raises KeyError: "No event with id='BOGUS...'."

After adding ?includeComments=true, the singular response shape matches the list-endpoint element exactly: 29 keys vs 29 keys, set difference is empty. get_event() output is a drop-in replacement for [e for e in get_events() if e["id"]==uid][0].

Why ?includeComments=true instead of a second API call

Initially the plan was two calls (singular + /sponds/{uid}/comments) and merging. Probed three options first:

• ?includeComments=true ✅ — returns comments inline, one call, exact list-endpoint shape
• /sponds/{uid}/comments ✅ — works as a separate sub-resource, but requires merging
• /sponds/{uid}/posts ❌ — 404

One call with a query param is strictly cleaner.

Incidental fix

update_event() also calls _get_entity(EVENT, ...), so it had the same latent bug for events outside the cached window. Fixed automatically by this refactor.

Stacked behind #235

Branched off fix/get-entity-handles-empty-results. Merge #235 first, then this. (PR base retargeted to main so CI fires; once #235 merges, the diff cleans up automatically.)

Test plan

• Live probe: real id returns event, ?includeComments=true adds the field, bogus id returns 404
• Live test of fixed code: get_event(real_id) works, returns 29-key dict matching list-endpoint shape, get_event(bogus_id) raises KeyError
• Local pytest — 22 tests pass
• Local ruff check — clean
• Local ruff format --check — clean
• CI: full Python matrix green
• Suggested: rerun examples/manual_test_functions.py end-to-end before merge

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes Spond.get_event(uid) so it can return events that are beyond the default max_events=100 window or marked as scheduled. Previously _get_entity() for events routed through get_events() (with default filters), making such events unreachable. The fix replaces that path with a direct call to the singular sponds/{uid} endpoint and surfaces 404s as KeyError to preserve existing semantics. update_event() benefits from the same fix transparently.

Changes:

• In _get_entity(), route event lookups to a new _fetch_event_by_uid() helper that calls GET sponds/{uid} (with includeComments=true to keep response shape close to list elements); group lookups remain on the cached path.
• Add a KeyError guard for the empty-cache group case (the dependency from stacked PR #235).
• Replace the cache-based event tests with HTTP-mocked tests covering 200/404/500 paths and add a group-empty KeyError test; update the manual example to exercise the new path.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
spond/spond.py	Routes _get_entity for events through new _fetch_event_by_uid (singular endpoint, 404→KeyError, other errors→ValueError); keeps group cache path with empty-cache KeyError guard.
tests/test_spond.py	Replaces cached-list event tests with HTTP-mocked happy-path/404/500 tests; adds empty-groups KeyError test.
examples/manual_test_functions.py	Adds a get_event(events[0]["id"]) step and reuses e for the existing attendance export.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.