fix: prevent URLSpan(null) crash on unedited link tap#171
Open
Arvuno wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash when tapping an unedited link (one that was inserted but never had its URL set via the edit dialog).
Problem
When a link is inserted from the toolbar without being edited,
URLSpan(null)is created with a null URL. When tapped, theLinkMovementMethodcallback inTakeNote.ktcallsUri.parse(link)wherelinkis null, causing a crash.Fix
In the 'Open Link' handler, check if
span.URLis null before attempting to parse and open it. If null, display the 'Can't open link' toast instead of crashing.Changes
TakeNote.ktto usespan.URLdirectly and guard against null valuesTesting