Added purgetoid and factbook#1
Open
aleph-oh wants to merge 4 commits intoOmnicsat:masterfrom
Open
Conversation
added 4 commits
February 21, 2020 17:19
Deletes messages until it finds a specified channel id. If this isn't possible, deletes nothing.
added a semicolon, otherwise irrelevant
Adds factbook command that, when run with a valid nation name, returns a valid link to said nation's factbook. Automatically tries to convert spaces in names to underscores as well. possible places to improve: -mapping nation nicknames to the nation via switch-casing -somehow returning that usernames aren't valid (hard to check sites for validity w/o a webserver to check and parse them, which is quite a bit of work and not just code)
Author
|
added factbook command as well, camelCased purgeToID for clarity's sake factbook command is very much non-ideal b/c it doesn't check to see if the target link exists, but this is non-trivial b/c it requires testing the link with a web server, which varies in implementation (and complexity) based on the server/computer envision is hosted on (which I don't know and don't expect to). (also, same disclaimer with regard to functionality: no obvious syntax problems, can't know if it'll run at the moment) |
Owner
|
I sort of forgot about implementing this, maybe I’ll get around to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a command that queues messages to delete until it finds the specified message ID, and deletes the messages queued up to that point.
(Very much unsure if this will work, but it doesn't seem to have any syntax errors in it at somewhat more than a cursory glance.)