Skip to content

[The7] Added config file with override_local false - #371

Merged
dgwatkins merged 1 commit into
masterfrom
andrescifuentesr-patch-5
Jul 6, 2026
Merged

[The7] Added config file with override_local false#371
dgwatkins merged 1 commit into
masterfrom
andrescifuentesr-patch-5

Conversation

@andrescifuentesr

Copy link
Copy Markdown
Collaborator

@dgwatkins

Copy link
Copy Markdown
Collaborator

@andrescifuentesr do you know if "The7" author has been keeping his XML up to date? I am asking because as soon as I merge this, all "The7" users will stop receiving our XML and start using their local XML.

FYI: @gerasimovdaniel

@andrescifuentesr

Copy link
Copy Markdown
Collaborator Author

@gerasimovdaniel, do you think is better to wait until The7 new version is released and give time for your users to update and then remove it? Or maybe you just prefer to keep maintaining our repository as you did this morning?
Let us know your thoughts.

@gerasimovdaniel

gerasimovdaniel commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

@andrescifuentesr, I prefer to keep the XML in The7. We are keeping it up to date quite rigorously. Let's wait until the new version of The7 is released. Should I post here when it comes?

@andrescifuentesr

Copy link
Copy Markdown
Collaborator Author

@gerasimovdaniel, sure. Please let us know once the new version is released so we can go further.
Let's hold this on @dgwatkins.

@gerasimovdaniel

gerasimovdaniel commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

@dgwatkins @andrescifuentesr The7 new version is released.

@diiegopereira

Copy link
Copy Markdown
Contributor

Implementing this change may cause issues for users with older versions of The7 theme, where the new XML file has not yet been implemented. The WPML integration will suddenly stop working.

The solution in this case would be to keep both files synchronized (local and remote) for a while, until most users have updated the theme.

I talked to Yana via email and we decided to wait around a year to do this modification.

@dgwatkins

Copy link
Copy Markdown
Collaborator

@andrescifuentesr I think we can remove the comments, they are not adding value.

@andrescifuentesr

andrescifuentesr commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the heads up @dgwatkins, something went wrong on my local branch. Sorry for the noise.

@dgwatkins
dgwatkins force-pushed the andrescifuentesr-patch-5 branch from 8f01e3d to 5360dd5 Compare July 6, 2026 14:50
@dgwatkins

Copy link
Copy Markdown
Collaborator

@andrescifuentesr Let me know when we are safe to deploy this.

@andrescifuentesr

Copy link
Copy Markdown
Collaborator Author

Yes @dgwatkins, we are good to go with this, thanks!

@dgwatkins
dgwatkins merged commit 76675d8 into master Jul 6, 2026
1 check passed
@dgwatkins
dgwatkins deleted the andrescifuentesr-patch-5 branch July 6, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants