[The7] Added config file with override_local false - #371
Conversation
|
@andrescifuentesr do you know if "The7" author has been keeping his XML up to date? I am asking because as soon as I merge this, all "The7" users will stop receiving our XML and start using their local XML. FYI: @gerasimovdaniel |
|
@gerasimovdaniel, do you think is better to wait until The7 new version is released and give time for your users to update and then remove it? Or maybe you just prefer to keep maintaining our repository as you did this morning? |
|
@andrescifuentesr, I prefer to keep the XML in The7. We are keeping it up to date quite rigorously. Let's wait until the new version of The7 is released. Should I post here when it comes? |
|
@gerasimovdaniel, sure. Please let us know once the new version is released so we can go further. |
|
@dgwatkins @andrescifuentesr The7 new version is released. |
|
Implementing this change may cause issues for users with older versions of The7 theme, where the new XML file has not yet been implemented. The WPML integration will suddenly stop working. The solution in this case would be to keep both files synchronized (local and remote) for a while, until most users have updated the theme. I talked to Yana via email and we decided to wait around a year to do this modification. |
|
@andrescifuentesr I think we can remove the comments, they are not adding value. |
|
Thanks for the heads up @dgwatkins, something went wrong on my local branch. Sorry for the noise. |
8f01e3d to
5360dd5
Compare
|
@andrescifuentesr Let me know when we are safe to deploy this. |
|
Yes @dgwatkins, we are good to go with this, thanks! |
https://onthegosystems.myjetbrains.com/youtrack/issue/compsupp-7258/