refactor: extract ParseLocationParams helper to remove duplication across location handlers#746
Open
AhmedAlian7 wants to merge 1 commit intoOneBusAway:mainfrom
Open
Conversation
…ross location handlers
Member
|
@AhmedAlian7 please fix the merge conflicts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracts the duplicated location query parameter parsing logic shared across
three handlers into a single reusable helper.
Closes #745
Changes
internal/utils/api.goLocationParamsstruct holdingLat,Lon,LatSpan,LonSpan,RadiusParseLocationParams(q url.Values)which reuses existingParseRequiredFloatParamfor
lat/lon(required) andParseFloatParamfor the optional fieldsnilstruct pointer on any validation error, consistent with existing erroraccumulation pattern
internal/restapi/stops_for_location_handler.goParse*FloatParamcalls with a singleutils.ParseLocationParamscallinternal/restapi/routes_for_location_handler.gointernal/restapi/trips_for_location_handler.goParse*FloatParamcalls inparseAndValidateRequestwithutils.ParseLocationParamslocParams.Radiusis intentionally ignored — this handler does not use itinternal/utils/api_test.goAdded 8 test cases for
ParseLocationParams:Testing
make test make lint go fmt ./...