fix: schedule-for-route stop groupings, service IDs, and consolidated GTFS double prefix#794
Open
Ahmedhossamdev wants to merge 2 commits intomainfrom
Open
Conversation
…solidated GTFS feeds and update tests accordingly
…ing in schedule and stops handlers
Performance Smoke Test ResultsStatus: PASSED
Smoke test config: 5 VUs x 30s. Thresholds: p(95) < 300ms, error rate < 1%. Full results uploaded as workflow artifact: k6-smoke-summary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
#789
#790
#791
stopTripGroupings direction order, stop ordering, and headsigns didn't match Java OBA.
Extracted shared
groupTripsByDirectionhelper used by bothstops-for-routeandschedule-for-route.serviceIds was returning all active agency service IDs for the day instead of only the
ones used by trips on the queried route.
Double agency prefix on IDs from consolidated GTFS feeds (e.g. Puget Sound).
FormCombinedIDnow skips prefixing when the ID already starts with{agencyID}_or normalizes
{agencyID}-→{agencyID}_to avoid40_40-455style output.