Skip to content

Internationalize hardcoded aria-label strings#430

Open
adityakulraj wants to merge 1 commit intoOneBusAway:developfrom
adityakulraj:feature/adkunwar-i18n-aria-labels-406
Open

Internationalize hardcoded aria-label strings#430
adityakulraj wants to merge 1 commit intoOneBusAway:developfrom
adityakulraj:feature/adkunwar-i18n-aria-labels-406

Conversation

@adityakulraj
Copy link
Copy Markdown
Contributor

Summary

  • replace hardcoded aria-label="Clear" in TripPlanSearchField.svelte with $t('trip-planner.clear')
  • replace hardcoded aria-label="Required question" in SurveyQuestion.svelte with $t('survey.required_question')
  • add translation keys to src/locales/en.json

Validation

  • git diff --check
  • attempted npm run lint
    • blocked in this environment because local tooling install is incomplete (prettier binary missing)

Closes #406

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 24, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityakulraj please be sure tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internationalize hardcoded aria-label strings

3 participants