Skip to content

feat: add dark mode support to stop marker popup and fix related dark mode issues#445

Open
sannidhyaroy wants to merge 7 commits intoOneBusAway:developfrom
sannidhyaroy:fix/popup-content-dark-mode
Open

feat: add dark mode support to stop marker popup and fix related dark mode issues#445
sannidhyaroy wants to merge 7 commits intoOneBusAway:developfrom
sannidhyaroy:fix/popup-content-dark-mode

Conversation

@sannidhyaroy
Copy link
Copy Markdown

Summary

  • Add dark mode support to PopupContent.svelte (stop marker popup) [closes Add dark mode support to PopupContent.svelte (stop popup) #443]
  • Add dark mode overrides for Leaflet popup wrapper and tip (.leaflet-popup-content-wrapper, .leaflet-popup-tip)
  • Fix close button hover in ModalPane showing white background in dark mode
  • Add dark mode text color to "Route Schedules" heading on the schedule page

Screenshots

PopupContent (stop popup)

Before After
PopupContent pre-edit PopupContent

Leaflet popup wrapper (impacts both stop popup and vehicle popup)

Before After
VehiclePopupContent pre-edit VehiclePopupContent

ModalPane close button hover

Before After
Modal Pane close button hover pre-edit Modal Pane close button hover

Route Schedules heading

Before After
Schedule Page pre-edit Schedule Page

Additional Questions

The stop popup currently shows Arrival time: inside a purple badge. Since the badge already visually separates it from the time value, should the trailing colon be removed (i.e. just Arrival time)? I left it unchanged for now.

Test plan

  • Toggle dark mode and click a stop marker on a route map. Popup should have dark background with readable text
  • Verify Leaflet popup wrapper matches the dark background (no white border)
  • Hover over the close (X) button on any sidebar pane in dark mode and it should show subtle dark highlight, not white
  • Navigate to a stop's schedule page in dark mode and the "Route Schedules" heading should be readable
  • Verify all above still look correct in light mode
  • npm run lint passes

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 26, 2026

CLA assistant check
All committers have signed the CLA.

@sannidhyaroy sannidhyaroy marked this pull request as ready for review March 26, 2026 00:48
Copilot AI review requested due to automatic review settings March 26, 2026 00:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds/finishes dark-mode styling for stop marker popups and a few related UI elements to ensure consistent readability and remove light-theme artifacts when the app is in dark mode.

Changes:

  • Added dark: Tailwind classes to PopupContent.svelte (stop marker popup).
  • Added dark-mode CSS overrides for Leaflet popup wrapper/tip and adjusted modal close-button hover styling.
  • Fixed dark-mode text color for the “Route Schedules” heading.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/routes/stops/[stopID]/schedule/+page.svelte Adds dark-mode text color to the page heading for readability.
src/components/navigation/ModalPane.svelte Removes component-scoped close-button styling (moved global), leaving an empty style block.
src/components/map/PopupContent.svelte Adds dark-mode background/text classes to the stop popup content.
src/assets/styles/leaflet-map.css Adds .dark overrides for Leaflet popup wrapper/tip to prevent light borders/background.
src/app.css Centralizes .close-button styling and fixes dark-mode hover background color.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sannidhyaroy
Copy link
Copy Markdown
Author

sannidhyaroy commented Mar 26, 2026

Dropped the trailing colon from the "Arrival time" label as confirmed by @tarunsinghofficial in our Slack discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dark mode support to PopupContent.svelte (stop popup)

3 participants