feat: add dark mode support to stop marker popup and fix related dark mode issues#445
Open
sannidhyaroy wants to merge 7 commits intoOneBusAway:developfrom
Open
feat: add dark mode support to stop marker popup and fix related dark mode issues#445sannidhyaroy wants to merge 7 commits intoOneBusAway:developfrom
sannidhyaroy wants to merge 7 commits intoOneBusAway:developfrom
Conversation
Move `.close-button` styles from scoped PostCSS to global `app.css` so dark variants apply correctly.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/finishes dark-mode styling for stop marker popups and a few related UI elements to ensure consistent readability and remove light-theme artifacts when the app is in dark mode.
Changes:
- Added
dark:Tailwind classes toPopupContent.svelte(stop marker popup). - Added dark-mode CSS overrides for Leaflet popup wrapper/tip and adjusted modal close-button hover styling.
- Fixed dark-mode text color for the “Route Schedules” heading.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/stops/[stopID]/schedule/+page.svelte | Adds dark-mode text color to the page heading for readability. |
| src/components/navigation/ModalPane.svelte | Removes component-scoped close-button styling (moved global), leaving an empty style block. |
| src/components/map/PopupContent.svelte | Adds dark-mode background/text classes to the stop popup content. |
| src/assets/styles/leaflet-map.css | Adds .dark overrides for Leaflet popup wrapper/tip to prevent light borders/background. |
| src/app.css | Centralizes .close-button styling and fixes dark-mode hover background color. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Dropped the trailing colon from the "Arrival time" label as confirmed by @tarunsinghofficial in our Slack discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PopupContent.svelte(stop marker popup) [closes Add dark mode support to PopupContent.svelte (stop popup) #443].leaflet-popup-content-wrapper,.leaflet-popup-tip)ModalPaneshowing white background in dark modeScreenshots
PopupContent (stop popup)
Leaflet popup wrapper (impacts both stop popup and vehicle popup)
ModalPane close button hover
Route Schedules heading
Additional Questions
The stop popup currently shows
Arrival time:inside a purple badge. Since the badge already visually separates it from the time value, should the trailing colon be removed (i.e. justArrival time)? I left it unchanged for now.Test plan
npm run lintpasses