Fix: standardize /obaSdk imports (remove .js extension) to avoid modu…#459
Open
raj-aryan-official wants to merge 1 commit intoOneBusAway:developfrom
Open
Fix: standardize /obaSdk imports (remove .js extension) to avoid modu…#459raj-aryan-official wants to merge 1 commit intoOneBusAway:developfrom
raj-aryan-official wants to merge 1 commit intoOneBusAway:developfrom
Conversation
…le resolution issues
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458
Short description of what this resolves:
This PR fixes server-side 500 errors caused by inconsistent module imports of the OBA SDK. Standardizing the import pattern ensures reliable module resolution during SSR.
Changes proposed in this pull request:
$lib/obaSdk.jswith$lib/obaSdkto align with Vite/SvelteKit module resolutionFiles updated:
Checklist
[x] I have read the Contribution & Best practices Guide
[x] My branch is up-to-date with the upstream branch
[x] Changes tested locally and server runs without errors
[ ] Tests can be added for further validation if required
[ ] Documentation updates can be added if needed
Additional Notes:
This change ensures consistent module resolution across the codebase and prevents SSR-related runtime failures. Happy to verify further or extend with tests if required.