Skip to content

[Snyk] Security upgrade @expo/plist from 0.0.17 to 0.3.0 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
revan-zhang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade @expo/plist from 0.0.17 to 0.3.0 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533c409
fix: build-plist-edit/src/package.json & build-plist-edit/src/yarn.lo…
snyk-bot Apr 2, 2026
1d838f4
auto-build actions
github-actions[bot] Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-plist-edit/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build-plist-edit/src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"dependencies": {
"@actions/core": "^1.9.1",
"@expo/json-file": "^8.2.34",
"@expo/plist": "^0.0.17",
"@expo/plist": "^0.3.0",
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bundled index.js not rebuilt after dependency upgrade, so the vulnerability fix has no runtime effect

The PR updates @expo/plist from ^0.0.17 to ^0.3.0 in package.json and yarn.lock to reduce vulnerabilities, but the pre-compiled build-plist-edit/index.js bundle (which is what action.yml:19 actually executes via runs.main: 'index.js') was not rebuilt. The build step is ncc build index.ts -m -o ../ (build-plist-edit/src/package.json:7), which bundles all dependencies into a single index.js. Since index.js still contains the old @expo/plist@0.0.17 code (with vulnerable @xmldom/xmldom@~0.7.0 and xmlbuilder@^14.0.0), the upgrade has zero runtime effect — the action will continue running the old vulnerable code.

Prompt for agents 
The build-plist-edit action uses @vercel/ncc to bundle all source code and dependencies into a single build-plist-edit/index.js file, which is the actual entry point referenced in action.yml. The PR updated package.json and yarn.lock but did not re-run the build step (cd build-plist-edit/src && yarn build, which runs ncc build index.ts -m -o ../). As a result, the bundled index.js still contains the old @expo/plist@0.0.17 code with its vulnerable transitive dependencies. To fix: run 'yarn build' from the build-plist-edit/src directory and commit the regenerated index.js.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"fs-extra": "^10.0.1",
"minimist": "^1.2.6"
},
Expand Down
28 changes: 14 additions & 14 deletions build-plist-edit/src/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@
json5 "^1.0.1"
write-file-atomic "^2.3.0"

"@expo/plist@^0.0.17":
version "0.0.17"
resolved "https://registry.yarnpkg.com/@expo/plist/-/plist-0.0.17.tgz#0f6c594e116f45a28f5ed20998dadb5f3429f88b"
integrity sha512-5Ul3d/YOYE6mfum0jCE25XUnkKHZ5vGlU/X2275ZmCtGrpRn1Fl8Nq+jQKSaks3NqTfxdyXROi/TgH8Zxeg2wg==
"@expo/plist@^0.3.0":
version "0.3.5"
resolved "https://registry.yarnpkg.com/@expo/plist/-/plist-0.3.5.tgz#11913c64951936101529cb26d7260ef16970fc31"
integrity sha512-9RYVU1iGyCJ7vWfg3e7c/NVyMFs8wbl+dMWZphtFtsqyN9zppGREU3ctlD3i8KUE0sCUTVnLjCWr+VeUIDep2g==
dependencies:
"@xmldom/xmldom" "~0.7.0"
"@xmldom/xmldom" "^0.8.8"
base64-js "^1.2.3"
xmlbuilder "^14.0.0"
xmlbuilder "^15.1.1"

"@types/fs-extra@^9.0.13":
version "9.0.13"
Expand All @@ -73,10 +73,10 @@
resolved "https://registry.yarnpkg.com/@vercel/ncc/-/ncc-0.33.3.tgz#aacc6b3ea9f7b175e0c9a18c9b97e4005a2f4fcc"
integrity sha512-JGZ11QV+/ZcfudW2Cz2JVp54/pJNXbsuWRgSh2ZmmZdQBKXqBtIGrwI1Wyx8nlbzAiEFe7FHi4K1zX4//jxTnQ==

"@xmldom/xmldom@~0.7.0":
version "0.7.5"
resolved "https://registry.yarnpkg.com/@xmldom/xmldom/-/xmldom-0.7.5.tgz#09fa51e356d07d0be200642b0e4f91d8e6dd408d"
integrity sha512-V3BIhmY36fXZ1OtVcI9W+FxQqxVLsPKcNjWigIaa81dLC9IolJl5Mt4Cvhmr0flUnjSpTdrbMTSbXqYqV5dT6A==
"@xmldom/xmldom@^0.8.8":
version "0.8.12"
resolved "https://registry.yarnpkg.com/@xmldom/xmldom/-/xmldom-0.8.12.tgz#cf488a5435fa06c7374ad1449c69cea0f823624b"
integrity sha512-9k/gHF6n/pAi/9tqr3m3aqkuiNosYTurLLUtc7xQ9sxB/wm7WPygCv8GYa6mS0fLJEHhqMC1ATYhz++U/lRHqg==

ansi-styles@^3.2.1:
version "3.2.1"
Expand Down Expand Up @@ -207,7 +207,7 @@ write-file-atomic@^2.3.0:
imurmurhash "^0.1.4"
signal-exit "^3.0.2"

xmlbuilder@^14.0.0:
version "14.0.0"
resolved "https://registry.yarnpkg.com/xmlbuilder/-/xmlbuilder-14.0.0.tgz#876b5aec4f05ffd5feb97b0a871c855d16fbeb8c"
integrity sha512-ts+B2rSe4fIckR6iquDjsKbQFK2NlUk6iG5nf14mDEyldgoc2nEKZ3jZWMPTxGQwVgToSjt6VGIho1H8/fNFTg==
xmlbuilder@^15.1.1:
version "15.1.1"
resolved "https://registry.yarnpkg.com/xmlbuilder/-/xmlbuilder-15.1.1.tgz#9dcdce49eea66d8d10b42cae94a79c3c8d0c2ec5"
integrity sha512-yMqGBqtXyeN1e3TGYvgNgDVZ3j84W4cwkOXQswghol6APgZWaff9lnbvN7MHYJOiXsvGPXtjTYJEiC9J2wv9Eg==
16 changes: 11 additions & 5 deletions pr-impact-analysis/dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40701,15 +40701,21 @@ async function run() {
throw new Error(`Worker error: ${data.error}`);
}

// 3. Set outputs
core.setOutput('jira-issue-key', data.jiraIssueKey || '');
core.setOutput('jira-issue-url', data.jiraIssueUrl || '');
// 3. Validate and set outputs
const skipped = data.skipped === true;
core.setOutput('skipped', String(skipped));
core.setOutput('analysis-summary', data.analysisSummary || '');
core.setOutput('skipped', String(data.skipped));

if (data.skipped) {
if (skipped) {
core.setOutput('jira-issue-key', '');
core.setOutput('jira-issue-url', '');
core.info(`Skipped (${data.skipReason}): ${data.analysisSummary}`);
} else {
if (!data.jiraIssueKey || !data.jiraIssueUrl) {
throw new Error('Worker returned success but missing Jira issue key/url');
}
core.setOutput('jira-issue-key', data.jiraIssueKey);
core.setOutput('jira-issue-url', data.jiraIssueUrl);
core.info(`Done! Jira issue created: ${data.jiraIssueKey} — ${data.jiraIssueUrl}`);
}
} catch (error) {
Expand Down
8 changes: 4 additions & 4 deletions s3-upload/index.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading