Skip to content

[Snyk] Security upgrade eslint from 8.27.0 to 10.0.0 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
revan-zhang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade eslint from 8.27.0 to 10.0.0 #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"css-minimizer-webpack-plugin": "^3.2.0",
"dotenv": "^10.0.0",
"dotenv-expand": "^5.1.0",
"eslint": "^8.23.1",
"eslint": "^10.0.0",
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 ESLint major version bump to v10 breaks all linting due to incompatible legacy .eslintrc config and ESLint 8-era plugins

ESLint is bumped from ^8.23.1 to ^10.0.0 (resolving to 10.1.0 in the lockfile), but the project relies entirely on the legacy .eslintrc configuration format (.eslintrc:1-37) and the eslintConfig field in package.json:179-181. ESLint 9 deprecated .eslintrc support, and ESLint 10 removed it entirely — only flat config (eslint.config.js) is supported. Additionally, all ESLint plugins and configs are pinned to ESLint 8-compatible versions (e.g., @typescript-eslint/eslint-plugin: ^5.38.0, @typescript-eslint/parser: ^5.38.0, eslint-config-wesbos: ^3.0.2, eslint-plugin-react-hooks: ^4.6.0, eslint-config-react-app: ^7.0.1), which have peer dependencies on ESLint 8 and use the legacy plugin API. This will cause yarn lint, yarn lint:fix, and the eslint-webpack-plugin integration during yarn start/yarn build to fail.

Suggested change
"eslint": "^10.0.0",
"eslint": "^8.23.1",
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown

@cursor cursor bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint 10 breaks project's legacy eslintrc configuration

High Severity

Upgrading eslint from ^8.23.1 to ^10.0.0 will break linting entirely. ESLint 10 completely removed support for the legacy eslintrc configuration format, but this project defines its ESLint config via the eslintConfig field in package.json (using "extends": "react-app"), which is the legacy format. Additionally, all companion packages (eslint-config-airbnb, eslint-config-react-app, eslint-config-prettier, eslint-config-airbnb-typescript, eslint-config-wesbos, eslint-webpack-plugin, etc.) are pinned to versions that only support ESLint 8's legacy config and declare eslint@^8 as a peer dependency. The lint and lint:fix scripts will fail, and the webpack build may also break since eslint-webpack-plugin is configured.

Additional Locations (1)
Fix in Cursor Fix in Web

"eslint-config-airbnb": "^19.0.4",
"eslint-config-airbnb-typescript": "^16.2.0",
"eslint-config-prettier": "^8.5.0",
Expand Down
Loading
Loading