chore: [SDK-4768] add no-location Capacitor demo#30
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
db22be5 to
9e0fd8e
Compare
sherwinski
requested changes
Jun 11, 2026
sherwinski
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds a minimal Capacitor
demo-no-locationapp that builds withONESIGNAL_DISABLE_LOCATION=true.Details
Motivation
This provides a runnable example for the location-free Capacitor integration added in #29, similar to the React Native no-location demo.
Scope
This PR adds a focused example under
examples/demo-no-locationwith a small React UI, generated Android/iOS Capacitor projects, and setup scripts that sync native dependencies with the location module disabled. It does not change the SDK runtime implementation.Stacking
Stacked on #29.
Testing
Unit testing
No unit tests were added because this PR only adds a runnable demo app.
Manual testing
vp check srcbun run buildONESIGNAL_DISABLE_LOCATION=trueAndroid dependency resolution confirmed modularcore,notifications, andin-app-messagesartifactsONESIGNAL_DISABLE_LOCATION=true ./gradlew :onesignal-capacitor-plugin:compileDebugKotlinONESIGNAL_DISABLE_LOCATION=true ./gradlew assembleDebugONESIGNAL_DISABLE_LOCATION=true swift package describe --type jsonconfirmed packaged plugin omitsOneSignalLocationNSLocation...usage stringsAffected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor