Skip to content

chore: [SDK-4768] add no-location Capacitor demo#30

Merged
fadi-george merged 9 commits into
mainfrom
fadi/sdk-4768-demo-no-location
Jun 11, 2026
Merged

chore: [SDK-4768] add no-location Capacitor demo#30
fadi-george merged 9 commits into
mainfrom
fadi/sdk-4768-demo-no-location

Conversation

@fadi-george

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Adds a minimal Capacitor demo-no-location app that builds with ONESIGNAL_DISABLE_LOCATION=true.

Details

Motivation

This provides a runnable example for the location-free Capacitor integration added in #29, similar to the React Native no-location demo.

Scope

This PR adds a focused example under examples/demo-no-location with a small React UI, generated Android/iOS Capacitor projects, and setup scripts that sync native dependencies with the location module disabled. It does not change the SDK runtime implementation.

Stacking

Stacked on #29.

Testing

Unit testing

No unit tests were added because this PR only adds a runnable demo app.

Manual testing

  • vp check src
  • bun run build
  • ONESIGNAL_DISABLE_LOCATION=true Android dependency resolution confirmed modular core, notifications, and in-app-messages artifacts
  • ONESIGNAL_DISABLE_LOCATION=true ./gradlew :onesignal-capacitor-plugin:compileDebugKotlin
  • ONESIGNAL_DISABLE_LOCATION=true ./gradlew assembleDebug
  • ONESIGNAL_DISABLE_LOCATION=true swift package describe --type json confirmed packaged plugin omits OneSignalLocation
  • Confirmed generated app has no Android location permissions and no iOS NSLocation... usage strings

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

Made with Cursor

@fadi-george fadi-george requested a review from a team as a code owner June 10, 2026 18:15
Base automatically changed from fadi/sdk-4768 to main June 11, 2026 00:15
@fadi-george fadi-george force-pushed the fadi/sdk-4768-demo-no-location branch from db22be5 to 9e0fd8e Compare June 11, 2026 00:16
Comment thread examples/demo-no-location/setup.sh
Comment thread examples/demo-no-location/setup.sh
Comment thread examples/demo-no-location/android/gradle.properties
@fadi-george fadi-george requested a review from sherwinski June 11, 2026 01:23
@fadi-george fadi-george merged commit 0ea2c7e into main Jun 11, 2026
5 checks passed
@fadi-george fadi-george deleted the fadi/sdk-4768-demo-no-location branch June 11, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants