ci: fix release workflow clone collision when called from iOS SDK#159
Merged
Conversation
nan-li
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When this workflow is called from the iOS SDK repo via
workflow_call, the runner workspace path is.../OneSignal-iOS-SDK/OneSignal-iOS-SDK. Thegit clone ../OneSignal-iOS-SDKstep resolves back to the workspace directory itself, which already exists, causing exit code 128.This checks out the DotNet SDK into a
dotnet-sdksubdirectory and sets the default working directory accordingly, so../OneSignal-iOS-SDKresolves to a fresh sibling path instead of the workspace root.Test plan
workflow_callMade with Cursor