-
Notifications
You must be signed in to change notification settings - Fork 6
chore: add ci formatting checks and csharpier cleanup #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8624ef8
format cs using csharpier
fadi-george 1e787bc
add ci workflow
fadi-george 4b4037a
remove old unused tests
fadi-george aba2b3f
docs: add PR conventions and semantic commit rules
fadi-george 0f2d8cd
Potential fix for code scanning alert no. 10: Workflow does not conta…
fadi-george File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| --- | ||
| description: Conventions for pull request titles and body content | ||
| alwaysApply: true | ||
| --- | ||
|
|
||
| # Pull Request Conventions | ||
|
|
||
| ## PR Title | ||
|
|
||
| Use semantic/conventional commit prefixes in PR titles: | ||
|
|
||
| - `fix:` for bug fixes | ||
| - `feat:` for new features | ||
| - `chore:` for maintenance tasks (deps, CI, tooling) | ||
| - `refactor:` for code restructuring without behavior changes | ||
| - `docs:` for documentation-only changes | ||
| - `test:` for test-only changes | ||
|
|
||
| Example: `fix: resolve notification grouping on Android 14` | ||
|
|
||
| ## PR Body | ||
|
|
||
| Follow the repo's PR template at `.github/pull_request_template.md`. Every PR body must include: | ||
|
|
||
| 1. **One Line Summary** (required) | ||
| 2. **Motivation** (required) explaining why the change is being made | ||
| 3. **Scope** (recommended) describing what is and isn't affected | ||
| 4. **Testing** section with manual and/or unit testing details | ||
| 5. **Affected code checklist** with relevant items checked | ||
| 6. **Checklist** sections confirmed | ||
|
|
||
| Remove the instructional header block (between `<!-- START -->` and `<!-- END -->`) before submitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: Run Checks | ||
| permissions: | ||
| contents: read | ||
| on: | ||
| pull_request: | ||
| branches: | ||
| - "**" | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Install CSharpier | ||
| run: dotnet tool install -g csharpier | ||
|
|
||
| - name: Check formatting | ||
| run: csharpier check . | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
OneSignalSDK.DotNet.Android.Core.Binding/Transforms/EnumFields.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
OneSignalSDK.DotNet.Android.Core.Binding/Transforms/EnumMethods.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 41 additions & 24 deletions
65
OneSignalSDK.DotNet.Android.Core.Binding/Transforms/Metadata.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,44 @@ | ||
| <metadata> | ||
| <attr path="/api/package[@name='com.onesignal']" name="managedName">Com.OneSignal.Android</attr> | ||
| <attr path="/api/package[@name='com.onesignal.common']" name="managedName">Com.OneSignal.Android.Common</attr> | ||
| <attr path="/api/package[@name='com.onesignal.debug']" name="managedName">Com.OneSignal.Android.Debug</attr> | ||
| <attr path="/api/package[@name='com.onesignal.inAppMessages']" name="managedName">Com.OneSignal.Android.InAppMessages</attr> | ||
| <attr path="/api/package[@name='com.onesignal.location']" name="managedName">Com.OneSignal.Android.Location</attr> | ||
| <attr path="/api/package[@name='com.onesignal.notifications']" name="managedName">Com.OneSignal.Android.Notifications</attr> | ||
| <attr path="/api/package[@name='com.onesignal.session']" name="managedName">Com.OneSignal.Android.Session</attr> | ||
| <attr path="/api/package[@name='com.onesignal.user']" name="managedName">Com.OneSignal.Android.User</attr> | ||
| <attr path="/api/package[@name='com.onesignal.user.subscriptions']" name="managedName">Com.OneSignal.Android.User.Subscriptions</attr> | ||
| <attr path="/api/package[@name='com.onesignal.user.state']" name="managedName">Com.OneSignal.Android.User.State</attr> | ||
| <attr path="/api/package[@name='com.onesignal']" name="managedName">Com.OneSignal.Android</attr> | ||
| <attr path="/api/package[@name='com.onesignal.common']" name="managedName" | ||
| >Com.OneSignal.Android.Common</attr | ||
| > | ||
| <attr path="/api/package[@name='com.onesignal.debug']" name="managedName" | ||
| >Com.OneSignal.Android.Debug</attr | ||
| > | ||
| <attr path="/api/package[@name='com.onesignal.inAppMessages']" name="managedName" | ||
| >Com.OneSignal.Android.InAppMessages</attr | ||
| > | ||
| <attr path="/api/package[@name='com.onesignal.location']" name="managedName" | ||
| >Com.OneSignal.Android.Location</attr | ||
| > | ||
| <attr path="/api/package[@name='com.onesignal.notifications']" name="managedName" | ||
| >Com.OneSignal.Android.Notifications</attr | ||
| > | ||
| <attr path="/api/package[@name='com.onesignal.session']" name="managedName" | ||
| >Com.OneSignal.Android.Session</attr | ||
| > | ||
| <attr path="/api/package[@name='com.onesignal.user']" name="managedName" | ||
| >Com.OneSignal.Android.User</attr> | ||
| <attr path="/api/package[@name='com.onesignal.user.subscriptions']" name="managedName" | ||
| >Com.OneSignal.Android.User.Subscriptions</attr | ||
| > | ||
| <attr path="/api/package[@name='com.onesignal.user.state']" name="managedName" | ||
| >Com.OneSignal.Android.User.State</attr | ||
| > | ||
|
|
||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.events')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.exceptions')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.modeling')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.modules')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.services')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.threading')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.core')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.debug.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.inAppMessages.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.location.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.notifications.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.session.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.user.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.events')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.exceptions')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.modeling')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.modules')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.services')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.common.threading')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.core')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.debug.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.inAppMessages.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.location.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.notifications.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.session.internal')]" /> | ||
| <remove-node path="/api/package[starts-with(@name, 'com.onesignal.user.internal')]" /> | ||
| </metadata> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
OneSignalSDK.DotNet.Android.InAppMessages.Binding/Transforms/EnumFields.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
OneSignalSDK.DotNet.Android.InAppMessages.Binding/Transforms/EnumMethods.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
OneSignalSDK.DotNet.Android.InAppMessages.Binding/Transforms/Metadata.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| <metadata> | ||
| <attr path="/api/package[@name='com.onesignal.inAppMessages']" name="managedName">Com.OneSignal.Android.InAppMessages</attr> | ||
| <attr path="/api/package[@name='com.onesignal.inAppMessages']" name="managedName" | ||
| >Com.OneSignal.Android.InAppMessages</attr | ||
| > | ||
| </metadata> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
OneSignalSDK.DotNet.Android.Location.Binding/Transforms/EnumFields.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
OneSignalSDK.DotNet.Android.Location.Binding/Transforms/EnumMethods.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
OneSignalSDK.DotNet.Android.Location.Binding/Transforms/Metadata.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| <metadata> | ||
| <attr path="/api/package[@name='com.onesignal.location']" name="managedName">Com.OneSignal.Android.Location</attr> | ||
| <attr path="/api/package[@name='com.onesignal.location']" name="managedName" | ||
| >Com.OneSignal.Android.Location</attr | ||
| > | ||
| </metadata> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
OneSignalSDK.DotNet.Android.Notifications.Binding/Transforms/EnumFields.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
OneSignalSDK.DotNet.Android.Notifications.Binding/Transforms/EnumMethods.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
OneSignalSDK.DotNet.Android.Notifications.Binding/Transforms/Metadata.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| <metadata> | ||
| <attr path="/api/package[@name='com.onesignal.notifications']" name="managedName">Com.OneSignal.Android.Notifications</attr> | ||
| <attr path="/api/package[@name='com.onesignal.notifications']" name="managedName" | ||
| >Com.OneSignal.Android.Notifications</attr | ||
| > | ||
| </metadata> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.