Skip to content

chore: [SDK-4220] add Live Activities support to demo app#170

Merged
fadi-george merged 11 commits into
mainfrom
fadi/sdk-4220-dotnet-sdk-live-activities
Apr 7, 2026
Merged

chore: [SDK-4220] add Live Activities support to demo app#170
fadi-george merged 11 commits into
mainfrom
fadi/sdk-4220-dotnet-sdk-live-activities

fix(demo): improve live activity button state logic

f42249f
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 7, 2026 in 13m 5s

Code review found 3 potential issues

Found 6 candidates, confirmed 3. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 2
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit examples/demo/Controls/Sections/LiveActivitiesSection.xaml.cs:61-81 START button not guarded by IsLiveActivityUpdating
🟡 Nit OneSignalSDK.DotNet.Core/LiveActivities/ILiveActivities.cs:22 Misleading [Obsolete] message on Exit() - method is functional on iOS

Annotations

Check warning on line 81 in examples/demo/Controls/Sections/LiveActivitiesSection.xaml.cs

See this annotation in the file changed.

@claude claude / Claude Code Review

START button not guarded by IsLiveActivityUpdating

The START button's enabled state is never updated when `IsLiveActivityUpdating` becomes true — `RefreshUpdateEndButtons()` correctly disables UPDATE and END during an in-flight async call, but `StartButton.IsEnabled` is only managed in `OnActivityIdChanged` based on text content alone. A user can tap START while an UPDATE or END REST call is in-flight, causing `StartDefault()` to be called on the SDK concurrently with an active update/end request for the same `activityId`. Fix by also incorporat

Check warning on line 22 in OneSignalSDK.DotNet.Core/LiveActivities/ILiveActivities.cs

See this annotation in the file changed.

@claude claude / Claude Code Review

Misleading [Obsolete] message on Exit() - method is functional on iOS

The [Obsolete] message 'Currently unsupported, avoid using this method.' on ILiveActivities.Exit() is factually inaccurate for iOS: iOSLiveActivitiesManager.Exit() is fully implemented and calls OneSignalNative.LiveActivities.Exit() with success/failure callbacks. A more accurate message would be 'Deprecated: use the REST API to end live activities instead.' since the PR's stated intent is to deprecate the method in favor of the REST API path, not to signal that the method does not work.