Skip to content

fix(android): add missing transitive deps for native core 5.8.0+ #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadi-george merged 2 commits into from
Apr 30, 2026
Merged

fix(android): add missing transitive deps for native core 5.8.0+ #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bffec1
fix(android): add missing deps for native core 5.8.0+
fadi-george Apr 30, 2026
b6593e4
style: reformat conditional TargetFrameworks XML
fadi-george Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions OneSignalSDK.DotNet.Android/OneSignalSDK.DotNet.Android.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,23 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Xamarin.Kotlin.StdLib.Jdk8" Version="1.9.23.3" />
<PackageReference Include="Xamarin.KotlinX.Coroutines.Core" Version="1.6.4.2" />
<PackageReference Include="Xamarin.KotlinX.Coroutines.Android" Version="1.6.4.2" />
<PackageReference Include="Xamarin.KotlinX.Coroutines.Core" Version="1.7.3.3" />
<PackageReference Include="Xamarin.KotlinX.Coroutines.Android" Version="1.7.3.3" />
<!-- Required by FeatureFlagsJsonParser in native core 5.8.0+ -->
<PackageReference Include="Xamarin.KotlinX.Serialization.Json" Version="1.7.3.5" />
<PackageReference Include="Xamarin.AndroidX.CardView" Version="1.0.0.16" />
<PackageReference Include="Xamarin.AndroidX.Legacy.Support.V4" Version="1.0.0.14" />
<PackageReference Include="Xamarin.AndroidX.Browser" Version="1.4.0.2" />
<PackageReference Include="Xamarin.AndroidX.AppCompat" Version="1.4.2.1" />
<PackageReference Include="Xamarin.AndroidX.Work.Runtime" Version="2.7.1.5" />
<PackageReference Include="Xamarin.AndroidX.Work.Work.Runtime.Ktx" Version="2.7.1.5" />
<!-- Required by FeatureFlagsRefreshService in native core 5.8.0+ -->
<PackageReference Include="Xamarin.AndroidX.Lifecycle.ViewModel.Ktx" Version="2.6.2.3" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Runtime.Ktx" Version="2.6.2.3" />
<PackageReference Include="Xamarin.AndroidX.Activity.Ktx" Version="1.7.2.2" />
<PackageReference Include="Xamarin.Firebase.Messaging" Version="123.0.8" />
<!-- Dagger is required for FCM, should be a "transitive dependency" but is not due to this bug: https://github.com/xamarin/XamarinComponents/issues/1069 -->
<PackageReference Include="Xamarin.Google.Dagger" Version="2.41.0.2" />
<PackageReference Include="Xamarin.GooglePlayServices.Base" Version="118.1.0" />
<PackageReference Include="Xamarin.AndroidX.Work.Work.Runtime.Ktx" Version="2.7.1.5" />
</ItemGroup>
</Project>
10 changes: 8 additions & 2 deletions OneSignalSDK.DotNet.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,21 @@
</group>
<group targetFramework="net10.0-android21.0">
<dependency id="Xamarin.Kotlin.StdLib.Jdk8" version="1.9.23.3" />
<dependency id="Xamarin.KotlinX.Coroutines.Core" version="1.6.4.2" />
<dependency id="Xamarin.KotlinX.Coroutines.Android" version="1.6.4.2" />
<dependency id="Xamarin.KotlinX.Coroutines.Core" version="1.7.3.3" />
<dependency id="Xamarin.KotlinX.Coroutines.Android" version="1.7.3.3" />
<!-- Required by FeatureFlagsJsonParser in native core 5.8.0+ -->
<dependency id="Xamarin.KotlinX.Serialization.Json" version="1.7.3.5" />

<dependency id="Xamarin.AndroidX.CardView" version="1.0.0.16" />
<dependency id="Xamarin.AndroidX.Legacy.Support.V4" version="1.0.0.14" />
<dependency id="Xamarin.AndroidX.Browser" version="1.4.0.2" />
<dependency id="Xamarin.AndroidX.AppCompat" version="1.4.2.1" />
<dependency id="Xamarin.AndroidX.Work.Runtime" version="2.7.1.5" />
<dependency id="Xamarin.AndroidX.Work.Work.Runtime.Ktx" version="2.7.1.5" />
<!-- Required by FeatureFlagsRefreshService in native core 5.8.0+ -->
<dependency id="Xamarin.AndroidX.Lifecycle.ViewModel.Ktx" version="2.6.2.3" />
<dependency id="Xamarin.AndroidX.Lifecycle.Runtime.Ktx" version="2.6.2.3" />
<dependency id="Xamarin.AndroidX.Activity.Ktx" version="1.7.2.2" />

<dependency id="Xamarin.Firebase.Messaging" version="123.0.8" />
<!-- Dagger is required for FCM, should be a "transitive dependency" but is not due to this bug:
Expand Down
4 changes: 3 additions & 1 deletion OneSignalSDK.DotNet/OneSignalSDK.DotNet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
ships all four TFMs.
-->
<TargetFrameworks>net10.0;net10.0-android;netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(TargetFrameworks);net10.0-ios</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('OSX'))"
>$(TargetFrameworks);net10.0-ios</TargetFrameworks
>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<LangVersion>10.0</LangVersion>
Expand Down
4 changes: 3 additions & 1 deletion examples/demo/demo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
NETSDK1178 looking for Microsoft.iOS.Sdk.
-->
<TargetFrameworks>net10.0-android</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(TargetFrameworks);net10.0-ios</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('OSX'))"
>$(TargetFrameworks);net10.0-ios</TargetFrameworks
>
<OutputType>Exe</OutputType>
<RootNamespace>OneSignalDemo</RootNamespace>
<UseMaui>true</UseMaui>
Expand Down
Loading