Skip to content

ci: update SVN deploy message#426

Merged
sherwinski merged 1 commit into
mainfrom
ci/release/update-deploy-message
May 22, 2026
Merged

ci: update SVN deploy message#426
sherwinski merged 1 commit into
mainfrom
ci/release/update-deploy-message

Conversation

@sherwinski

Copy link
Copy Markdown
Contributor

One Line Summary

Updates the commit message to be more consistent with past releases. This is what gets displayed on https://plugins.trac.wordpress.org/browser/onesignal-free-web-push-notifications/trunk

Motivation

Consistency in SVN commit messages

Scope

  • Affected: Publishing update to SVN
  • Not affected:

Testing

N/A

Affected code checklist

  • PHP plugin code (v3/)
  • v2/ legacy code
  • JS / CSS assets
  • Build / CI
  • Tests
  • Documentation (README, readme.txt, etc.)

Checklist

  • Code follows existing style in the touched files
  • Tested manually in the relevant editor(s)
    • Gutenberg/Block editor
    • Classic editor
  • No new lint or test errors introduced
  • Linear ticket / GitHub issue linked above
  • readme.txt and plugin version bumped if user-facing (release PRs only)

@sherwinski sherwinski requested a review from fadi-george May 22, 2026 17:19

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — trivial one-line tweak to the SVN commit message template.

Extended reasoning...

Overview

This PR changes a single line in .github/workflows/publish-svn.yml, swapping the SVN commit message from "Deploy v${version} to trunk" to "${version} release" to match the format used in past WordPress.org plugin releases.

Security risks

None. The change only affects the human-readable commit message text passed to svn commit -m. It does not alter authentication, secret handling, file selection/rsync rules, tagging logic, or any other behavior. The interpolated value (steps.version.outputs.bare) is the same value used elsewhere in the workflow and is derived from the git tag.

Level of scrutiny

Very low. This is a cosmetic CI change with no functional impact on what gets published or how. The only observable difference is the message displayed in the WordPress.org plugin trac browser.

Other factors

The change is self-contained, the motivation (consistency with past release messages) is clearly stated, and the bug hunting system flagged nothing.

@sherwinski sherwinski merged commit 4a38d0f into main May 22, 2026
10 checks passed
@sherwinski sherwinski deleted the ci/release/update-deploy-message branch May 22, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants