Issue 972 Debugging & tidy-up #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the documentation says 0x1 is label, but was actually 0x2. Swap them around.
Add toString() as a repr-like method to use in debugging. Show how to use it in console.log & use it as the default debug label for nodes.
Early exit for the unlikely !node.dvar case, remove length assignments, document code blocks.
The main reanchor() doesn't need a deanchor() first, so neither should reanchor_at_node(). This also means that the deanchor export is no longer required.
Combine them together to reduce mental load. And it doesn't check that the node is *in* (i.e. contained by), but *on* (i.e. a bit is visible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the ~unrelated tidy-ups and/or debugging helpers from #981 / #972
They won't help solve the problem, but some QoL improvements whilst trying to debug what's going on.