Condense installation into oz_tree_build/README#116
Merged
Conversation
There is very likely no /usr/bin/python set up on the OS nowadays, assuming python3 is more C+P-friendly.
The OpenTree API returns . and uses . in it's URL, so using a . here
too means we can use the environment variable to fetch a given version
directly.
Otherwise it just seems to be a convention to
draftversion${OT_VERSION}.tre naming, so shouldn't upset anything else.
Collect together the required setup steps from /README & data/README into oz_tree_build, so it's closer to a single runnable script. * Set environment variables from /README * Summarise/script download steps from data/REAME
Someone might have forgotten...
The script tries to empty it, if there's nothing there it will fall over. As a quick bodge, put something in it before deleting it.
There doesn't seem to be any explicit step to untar the taxonomy, so add one here.
lentinj
force-pushed
the
documentation-updates
branch
from
9a7e3ee to
fb3093a
Compare
If we just give it the tarball, then we try and read the tar as file contents. Which nearly works, bar the tarball noise at either end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include all the relevant downloads & environment variables in oz_tree_build, so it's more of a one-stop-shop for building a tree.
Include examples of fetching data using wget, based on OT environment variables. To do this we need to change
OT_VERSIONto "15.2" rather than "15_2", but given this only seems to affect the naming of draftversions, it should be fine.