Skip to content

Rename page parameter to page_url in extract_page_content for clarity #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Rename page parameter to page_url in extract_page_content for clarity #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bf5b2b
Initial plan
Copilot Nov 28, 2025
cf5d5bc
Rename page parameter to page_url in extract_page_content for clarity
Copilot Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions python/crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,13 @@ async def get_noticias_urls(self, num=50):

return noticias_urls

async def extract_page_content(self, page):
async def extract_page_content(self, page_url):
self.logger.send_log(
message=f"Starting content extraction for page: {page}",
message=f"Starting content extraction for page: {page_url}",
labels={"job": "web_crawler", "event": "page_content_extraction"}
)

await self.page.goto(page)
await self.page.goto(page_url)
title = await self.page.query_selector('h1')
content = await self.page.query_selector('#main-box')

Expand All @@ -174,11 +174,11 @@ async def extract_page_content(self, page):
page_data = {
"title": title_text,
"content": content_text,
"type": "noticia" if "latest-news" in page else "general",
"type": "noticia" if "latest-news" in page_url else "general",
}

os.makedirs("data", exist_ok=True)
filename = os.path.join("data", f"{page.replace('/', '_').replace(':', '')}.json")
filename = os.path.join("data", f"{page_url.replace('/', '_').replace(':', '')}.json")

try:
with open(filename, "w", encoding="utf-8") as f:
Expand Down