feat: table-embedded images, size filter, and doc_nav top_summary - #221
Merged
Conversation
- Introduced a new function to persist the document-level top_summary in doc_nav.json, ensuring it is saved after enrichment. - Updated `enrich_doc_nav_summaries` to support an opt-in flag for using LLM for top_summary generation, defaulting to true. - Refactored existing logic to prioritize loading enriched summaries from disk, improving efficiency and reducing unnecessary recomputation. - Adjusted related tests to validate the new functionality and ensure correct behavior of top_summary persistence. This update enhances the document navigation process by ensuring that summaries are consistently saved and retrieved, improving overall user experience.
- Updated the summary builder to improve document-level top summary generation, ensuring child contributions are deterministically summarized without LLM unless specified. - Enhanced inline asset handling to support table-embedded images, allowing for dynamic type assignment based on image references. - Introduced image size filtering across various document formats to skip undersized images, improving overall processing efficiency. - Refactored markdown image asset handling to include new properties for better management of image renaming and deferred tasks. - Improved table asset handling to include image references, ensuring that images embedded in tables are correctly processed and displayed. These updates collectively enhance the document parsing capabilities, streamline image handling, and improve the overall user experience in document navigation and summary generation.
Co-authored-by: Cursor <cursoragent@cursor.com>
EricNGOntos
added a commit
that referenced
this pull request
Jul 24, 2026
Keep test_summary_builder.py from main (#221); it was deleted on this branch unrelated to asset probing. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<img>as normal image assets (rename, VLM summary, HTMLsrcrewrite) with text/tableembedsassociations for retrieval.IMG_MIN_SIZEgate viaimage_size_filteracross DOCX, standalone image parse, and PDF→Markdown (including table images), discarding undersized files before rename/LLM.top_summaryondoc_nav.jsonand keep retrieval hydration/rendering wired for table-embedded images.Test plan
make check(ruff + pyright)pytestfocused:test_table_embedded_images_contract,test_image_size_filter_contract,test_summary_builderSJSYJ-MS201-2023…) and confirm logos<10KBdropped while flowchart images remainMade with Cursor