fix: accept result_mode as compatibility extra field - #235
Open
gdccyuen wants to merge 1 commit into
Open
Conversation
Dashboard still sends result_mode in job creation requests but the API removed it. Add to _PUBLIC_COMPATIBILITY_EXTRA_FIELDS so it's silently ignored instead of rejecting the whole request with 400.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The dashboard's upload flow (
file-upload-flow.tsx) sendsresult_modein the job creation payload, but the API removed this field. The request is rejected with400 Unsupported job-create fields.Fix
Add
result_modeto_PUBLIC_COMPATIBILITY_EXTRA_FIELDSinapps/api/app/services/document_ingestion/service.pyso it's silently ignored instead of rejecting the whole request.Context
result_modewas removed fromJobMetadata(comment: "result_mode was removed and is no longer supported")JobCreatetype still includesresult_mode: "auto" | "inline" | "url"(server/external-api/jobs.ts)400 Bad Requestagainst the current APIVerification
Tested end-to-end with a local Docker Compose deployment — uploads succeed after this fix.