Merged
Conversation
added 3 commits
February 24, 2026 11:40
…re manifest.plist. The macro OO_VERSION_FULL is set to contain the full version string right off the GNUmakefile build command. The full version string is now set under the version key in the core manifest.plist. Additionally, the build type is now also inlined in the core manifest.plist under the key debug_functionality_disabled, which takes a yes/no value depending on whether we are building deployment or not.
… title screen when the -showversion argument is used. Also, fixed snapshot build watermark not showing the game version.
mcarans
reviewed
Feb 24, 2026
mcarans
reviewed
Feb 24, 2026
mcarans
reviewed
Feb 24, 2026
mcarans
approved these changes
Feb 24, 2026
Contributor
mcarans
left a comment
mcarans
left a comment
There was a problem hiding this comment.
Looks great to me. I suggested some small improvements.
AnotherCommander
force-pushed
the
version_full_inline
branch
from
dc76e30 to
fa71725
Compare
… the key debug_functionality_disabled to debug_functionality_support, where yes means a test release or snapshot build and no means a deployment build.
Contributor
|
Super, I resolved all the comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full version string is now inlined in the game files and the executable itself.
The macro
OO_VERSION_FULL, representing the full version string (e.g. "1.93.0.7779-260224-dc76e30"), is now defined at the command line during compile time for all C and Obj-C files in the project. This allows easy access to the version string from practically everywhere.The full version string is added to the
[-]-helpoutput, as well as the main menu screen when the-showversioncommand line argument is used. The full version is now also printed in the log header and is now the version reported for all core world scripts.In addition to all the above, this PR embeds the full version string to the core resources manifest.plist file, replacing the previous
Maj.Minversion format under theversionkey. The build type is also inlined in manifest.plist under the keydebug_functionality_disabled, which takes theyes/novalues.yesimplies a deployment build,noimplies a test release or a snapshot build.