Update partners right after creating partnered control function#671
Merged
ad3154 merged 1 commit intoOpen-Agriculture:mainfrom Mar 10, 2026
Merged
Update partners right after creating partnered control function#671ad3154 merged 1 commit intoOpen-Agriculture:mainfrom
ad3154 merged 1 commit intoOpen-Agriculture:mainfrom
Conversation
Context: Prevents dropping the first message to an available external control function when its handler is created at the moment of sending the message.
ad3154
approved these changes
Mar 10, 2026
Member
ad3154
left a comment
ad3154
left a comment
There was a problem hiding this comment.
handle for the control function was created on demand when the message was sent. Interesting
Interesting... that is not my typical pattern, but I suppose that makes sense. Good enhancement, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
While testing our application, we noticed that the first message to an available external control function was being dropped. Even after being notified about the CF being available.
The reason was that the
PartneredControlFunctionhandle for the control function was created on demand when the message was sent. The network manager thread has to callupdate_new_partners()to enable the handle to send a message to the external control function.Calling
update_new_partners()immediately after creating the partnered handle fixes this issue for us.How has this been tested?
Adds a unit test to test the exact scenario