Open
Conversation
A frequent source of CI failures (here, but mostly elsewhere) is not pinning your compiler version. As new versions are released, new lints and errors are added, making a project that used to build without errors, now fail simply because there's a new release. Now, we can, and SHOULD frequently upgrade our toolchain, but it should still be pinned, so that we can do it on our terms. Closes #36.
Notgnoshi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 11.52% 11.21% -0.32%
==========================================
Files 17 17
Lines 2664 2613 -51
==========================================
- Hits 307 293 -14
+ Misses 2357 2320 -37 ☔ View full report in Codecov by Sentry. |
I suspect this lint was added to clippy since we last merged to main, and that the CI/CD pipeline uses the latest clippy release.
This was a new lint added since the Object enum was first merged.
warning: variant name starts with the enum's name
--> src/object_pool/object.rs:44:5
|
44 | ObjectPointer(ObjectPointer),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35.
Closes #36.