Open
Conversation
robertbaldyga
force-pushed
the
composite-detach
branch
5 times, most recently
from
c7642b0 to
4c94656
Compare
It is recurring pattern in OCF. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Since the free_detached partition will have the same ID as the freelist (due to limited number of available IDs) requesting cache lines with part id set to PARTITION_FREELIST would end up with accessing unavailable (detached) cache lines. However, at the point of calling `lru_req_next_cline()` the freelist is empty anyway as the eviction algorithm makes sure that the whole cache is populated before trying to move cachelines between the user parts. Thus, it is safe to assume that all cache lines with part id == PARTITION_FREELIST are detached and this change doesn't modify the OCF's behavior. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
An additional partition to store cache lines that belonged to detached members of composite volume. Keeping track of such cache lines will allow to easily reuse them once the missing composite volume member will be readded. The unavaliable cache lines will be moved to free_detached part, however because of the limited number of available part_ids the unavailable cache lines will have assigned PARTITION_FREE as partition id in metadata. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
It allows to move free detached cache lines back into the freelist. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Show OCF_COMPOSITE_VOLUME_MEMBERS_MAX in OCF public API, as it may be useful in adapter implementation. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Call on_init() properly in situation when uuid==NULL. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Those values are going to be needed for composite volume attach/detach operations, which could be performed before the volume is opened. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Avi Halaf <avi.halaf@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
robertbaldyga
force-pushed
the
composite-detach
branch
from
4c94656 to
43f020b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.