pyocf: Avoid disarm() attempt for not-registered volumes#926
Merged
robertbaldyga merged 1 commit intoOpen-CAS:masterfrom Feb 16, 2026
Merged
pyocf: Avoid disarm() attempt for not-registered volumes#926robertbaldyga merged 1 commit intoOpen-CAS:masterfrom
robertbaldyga merged 1 commit intoOpen-CAS:masterfrom
Conversation
An example of such volume is composite_volume, which is internal OCF implementation, thus does not have pyocf specific features, like disarm(). It is also not registered in Volume._instances_, because registration of pyocf volumes is done in open() callback, which for composite_volume is implemented internally in OCF. Co-developed-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
robertbaldyga
force-pushed
the
composite-no-disarm
branch
from
ee93516 to
74b9eac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example of such volume is composite_volume, which is internal OCF implementation, thus does not have pyocf specific features, like disarm(). It is also not registered in Volume.instances, because registration of pyocf volumes is done in open() callback, which for composite_volume is implemented internally in OCF.
Co-developed-by: Claude Opus 4.6 noreply@anthropic.com