Fix generated cflags in LLVM/Clang for Star-MC3 #2341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@AlbertHuang-CPU please double check and confirm |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
=======================================
Coverage 64.43% 64.43%
=======================================
Files 145 145
Lines 25997 25997
Branches 15666 15666
=======================================
Hits 16750 16750
Misses 7083 7083
Partials 2164 2164
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Test Results 7 files 53 suites 4m 49s ⏱️ Results for commit cede54e. |
Contributor
to align with llvm, we need to change Star-MC3 to be "star-mc3". |
JonatanAntoni
commented
Jan 30, 2026
| endif() | ||
| elseif(CPU STREQUAL "Star-MC3") | ||
| set(CLANG_ARCH "armv8.1m.main") | ||
| set(CPU_FEATURES "Star-MC3") |
Member
Author
There was a problem hiding this comment.
Flags are typically written in lower case. But usually they are evaluated case-insensitive, thats why my tests passed anyhow.
Suggested change
| set(CPU_FEATURES "star-mc3") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.