Skip to content

Add origin check for message events in TreeTable component#1034

Merged
jreineckearm merged 2 commits into
mainfrom
fix-alert
Jun 25, 2026
Merged

Add origin check for message events in TreeTable component#1034
jreineckearm merged 2 commits into
mainfrom
fix-alert

Conversation

@jthuangarm

@jthuangarm jthuangarm commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Add an origin check to the webview message handler so it ignores messages that aren't from the same origin.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh

qltysh Bot commented Jun 25, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@jthuangarm jthuangarm requested a review from jreineckearm June 25, 2026 09:04

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can confirm in a debugger that now only messages coming from the current window are processed. Let's see if that fixes the alert.

Side note: something's broken with loading the JS map file for tree-table.tsx. But not important now as one can still debug the transpiled JS output.

@jreineckearm jreineckearm merged commit 17b8e46 into main Jun 25, 2026
21 checks passed
@jreineckearm jreineckearm deleted the fix-alert branch June 25, 2026 13:45
@jreineckearm

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants