Implement TX_PLAN_SECURITY_RETRACTION validation rules#134
Draft
JSv4 wants to merge 1 commit intofeat/plan-security-acceptance-validationfrom
Draft
Implement TX_PLAN_SECURITY_RETRACTION validation rules#134JSv4 wants to merge 1 commit intofeat/plan-security-acceptance-validationfrom
JSv4 wants to merge 1 commit intofeat/plan-security-acceptance-validationfrom
Conversation
2 tasks
JSv4
force-pushed
the
feat/plan-security-retraction-validation
branch
from
4bad305 to
d6485e5
Compare
JSv4
force-pushed
the
feat/plan-security-acceptance-validation
branch
2 times, most recently
from
80d467c to
9b9f9b1
Compare
Replaces stub validator with real validation logic: - Validates plan security issuance exists in current state - Validates date is on or after the issuance date - Validates no prior acceptance exists for this security Wires TX_PLAN_SECURITY_RETRACTION into the XState machine. On retraction, removes the security from planSecurityIssuances context.
JSv4
force-pushed
the
feat/plan-security-retraction-validation
branch
from
d6485e5 to
7584a7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TX_PLAN_SECURITY_RETRACTIONvalidator with real validation logicTX_PLAN_SECURITY_RETRACTIONinto the XState machineplanSecurityIssuancescontextStack
PR 3/4 — based on #133 (acceptance)
Test plan
Closes #46