Move the per-agent model override to the settings page; drop the chat Settings tab - #549
Merged
Merged
Conversation
The chat Settings tab's only host — the unpinned /chat route — is dead under the home redesign, leaving the per-agent model override unreachable. Move the control to the settings page as an "Agent model" card adjacent to the Default model control, inside the provider section managed deployments hide. The card keeps the SettingsTab contract: active-agent scope, the default agent's picks routed through the two-layer default-model write, and the snapshot-not-live-link "Use default model" semantics. Remove the dead tab plumbing: SettingsTab.tsx, the ChatTabBar settings entry, the hideSettingsTab/isPinned props and the settings-tab reset effect in ChatSurface, and the chat page / TopicPanel wiring. Update ADRs per-agent-provider-settings.md and model-first-selection.md to describe the new surface. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hideSettingsTabprop, and the settings-only reset effect are removed.Test plan
bun run typecheck;bun run test— main 4803 pass / 0 fail, web 640 pass / 0 fail with coverage gate🤖 Generated with Claude Code