fix(capsule): keep confirm icon inside pill on done/error states#260
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
H-Chris233
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
摘要
修复 capsule 在 done/error 状态下确认图标溢出 pill 的问题。
当 capsule 进入 done 或 error 状态时,确认图标可能会在视觉上超出 pill 边界。本 PR 将确认图标保持在 capsule pill 内部,同时保留现有的布局行为。
修复 / 新增 / 改进
兼容
测试计划
npm run buildcargo check --manifest-path src-tauri/Cargo.tomlPR Type
Bug fix
Description
Replace fixed widths with flexible constraints
Add min-width:0 to inner elements and flex container
Preserve existing visual spacing and behavior
Diagram Walkthrough
File Walkthrough
Capsule.tsx
Constrain pill content with flexible widths to prevent overflowopenless-all/app/src/components/Capsule.tsx
CenterText span
buttons