Skip to content

fix(homebrew): bump cask to 1.2.23, drop broken Formula#326

Merged
appergb merged 1 commit into
mainfrom
fix/homebrew-cask-cleanup
May 7, 2026
Merged

fix(homebrew): bump cask to 1.2.23, drop broken Formula#326
appergb merged 1 commit into
mainfrom
fix/homebrew-cask-cleanup

Conversation

@appergb
Copy link
Copy Markdown
Collaborator

@appergb appergb commented May 7, 2026

User description

Summary

PR #322 落地后的两处遗留收尾,作者在该 PR 描述里已明确指出但保留给后续处理:

  • Cask 版本 1.2.22 → 1.2.23:合并 [feature] Add brew cask install option #322 时 cask 已落后 main 一版,新用户 `brew install --cask openless` 会先拿到旧版,再依赖 Tauri updater 拉到最新。这里手工补一刀,保证首装即最新。后续每次 release 由 `.github/workflows/update-cask.yml` 自动维护。
  • 删除 `Formula/openless.rb`:作者原话——「Tauri 的 DMG bundler 需要调用 hdiutil/create-dmg,在 Homebrew 沙盒里权限受限导致打包失败」。保留它会让误用 `brew install openless`(不带 `--cask`)的用户卡在编译失败上。Cask 路径已经覆盖了 macOS 安装需求,Formula 没必要。

SHA256 取自当前 `v1.2.23-tauri` release 资产的 `digest` 字段(GitHub API 实测返回值):

  • `OpenLess_1.2.23_aarch64.dmg` → `c6544555150459ba616ba43b27e226a88da40c5349c8e19f71a0bedfce7050b4`
  • `OpenLess_1.2.23_x64.dmg` → `ffcf84f5510ffe369277ddf9980b930fb5fb72a5e799020af4cf4720905625e1`

Test plan

  • `brew tap appergb/openless https://github.com/appergb/openless\` 成功
  • `brew install --cask openless` 下载 `OpenLess_1.2.23_aarch64.dmg`,SHA256 校验通过,安装到 `/Applications/OpenLess.app`
  • 启动后授权 Accessibility / Microphone,全局热键和录音正常
  • `brew install openless`(不带 `--cask`)应直接报「找不到 formula」,而不是开始编译然后失败

PR Type

Bug fix, Enhancement


Description

  • Bump Cask version to 1.2.23 with updated SHA256 checksums

  • Remove broken Formula/openless.rb that fails to build

  • Prevent install-time confusion from non‑functional formula


Diagram Walkthrough

flowchart LR
  A["Casks/openless.rb version 1.2.22 ⟶ 1.2.23"] --> B["First install delivers latest release"]
  C["Remove Formula/openless.rb"] --> D["Eliminate sandbox build failures"]
  B --> E["Clean Homebrew installation experience"]
  D --> E
Loading

File Walkthrough

Relevant files
Configuration changes
openless.rb
Bump Cask to 1.2.23 and refresh checksums                               

Casks/openless.rb

  • Updated version from 1.2.22 to 1.2.23
  • Replaced arm64 SHA256 with
    c6544555150459ba616ba43b27e226a88da40c5349c8e19f71a0bedfce7050b4
  • Replaced x64 SHA256 with
    ffcf84f5510ffe369277ddf9980b930fb5fb72a5e799020af4cf4720905625e1
+3/-3     
Bug fix
openless.rb
Remove broken Homebrew Formula                                                     

Formula/openless.rb

  • Deleted the entire Homebrew Formula (67 lines) that built the Tauri
    app from source
  • Removed sandbox‑failing build steps (hdiutil/create‑dmg)
  • Prevents brew install openless (without --cask) from blocking users
+0/-67   

- 把 Casks/openless.rb 从 1.2.22 升到 1.2.23 + 对应 SHA256,
  避免新用户首装拿到旧版(依赖 release 后 update-cask.yml 自动维护,
  但合并 PR322 时 cask 已落后一版,先手工补齐)。
- 删除 Formula/openless.rb:作者在 PR322 中已说明 Tauri DMG bundler
  在 Homebrew 沙盒构建里 hdiutil/create-dmg 受限会失败;保留会让
  误用 `brew install openless`(不带 --cask)的用户卡住。
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

322 - PR Code Verified

Compliant requirements:

  • Consider removing the Formula (now deleted)

Requires further human verification:

  • Verify that SHA256 checksums in Casks/openless.rb match the actual release assets (arm64 and x64 DMG files) to avoid installation failures
  • Ensure the existing CI workflow (update-cask.yml) still functions correctly with the updated cask file (requires manual trigger or testing)
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Incorrect SHA256

The SHA256 checksums were updated manually. If they do not match the corresponding release assets, brew install --cask openless will fail for all users. Verification against the actual OpenLess_1.2.23_aarch64.dmg and OpenLess_1.2.23_x64.dmg files is required before merging.

version "1.2.23"
sha256 arm:   "c6544555150459ba616ba43b27e226a88da40c5349c8e19f71a0bedfce7050b4",
       intel: "ffcf84f5510ffe369277ddf9980b930fb5fb72a5e799020af4cf4720905625e1"

@appergb appergb merged commit 8c0611f into main May 7, 2026
3 checks passed
@appergb appergb deleted the fix/homebrew-cask-cleanup branch May 10, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant