fix(homebrew): bump cask to 1.2.23, drop broken Formula#326
Merged
Conversation
- 把 Casks/openless.rb 从 1.2.22 升到 1.2.23 + 对应 SHA256, 避免新用户首装拿到旧版(依赖 release 后 update-cask.yml 自动维护, 但合并 PR322 时 cask 已落后一版,先手工补齐)。 - 删除 Formula/openless.rb:作者在 PR322 中已说明 Tauri DMG bundler 在 Homebrew 沙盒构建里 hdiutil/create-dmg 受限会失败;保留会让 误用 `brew install openless`(不带 --cask)的用户卡住。
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
PR #322 落地后的两处遗留收尾,作者在该 PR 描述里已明确指出但保留给后续处理:
SHA256 取自当前 `v1.2.23-tauri` release 资产的 `digest` 字段(GitHub API 实测返回值):
Test plan
PR Type
Bug fix, Enhancement
Description
Bump Cask version to 1.2.23 with updated SHA256 checksums
Remove broken Formula/openless.rb that fails to build
Prevent install-time confusion from non‑functional formula
Diagram Walkthrough
File Walkthrough
openless.rb
Bump Cask to 1.2.23 and refresh checksumsCasks/openless.rb
1.2.22to1.2.23c6544555150459ba616ba43b27e226a88da40c5349c8e19f71a0bedfce7050b4ffcf84f5510ffe369277ddf9980b930fb5fb72a5e799020af4cf4720905625e1openless.rb
Remove broken Homebrew FormulaFormula/openless.rb
app from source
brew install openless(without--cask) from blocking users