chore: bump version to 1.2.24-1 (Tauri MSI prerelease constraint)#337
Merged
Conversation
将 Beta 版本号从 1.2.24-beta.1 改为 1.2.24-1。 原因:Tauri MSI bundler 对 prerelease 段的限制比 npm/Cargo semver 严格, 要求 prerelease identifier 必须是「numeric-only and ≤ 65535」。 1.2.24-beta.1(含字母 + 多段)会让 windows MSI 构建直接报: failed to bundle project: optional pre-release identifier in app version must be numeric-only and cannot be greater than 65535 for msi target 实测后果:上次 v1.2.24-beta.1-beta-tauri tag 触发的 CI run 25501471895, macOS arm64 / macOS x64 / Linux 都成功,只有 Windows MSI 卡在 candle 之前。 修复: - 1.2.24-1 是合法的 npm/Cargo semver prerelease 写法( id="1" 纯数字) - Tauri MSI 接受这种格式 - semver 排序仍然 1.2.23 < 1.2.24-1 < 1.2.24,符合渠道隔离要求 - 后续 Beta 迭代版本号: 1.2.24-2 / 1.2.24-3 / ... - Beta 身份不靠版本字面,靠 tag 后缀 `-beta-tauri`(release-tauri.yml 检测) 5 处版本号同步:package.json、package-lock.json (root + nested)、 tauri.conf.json、Cargo.toml、Cargo.lock。CI 用的同一段 verify 通过。 合入后由维护者删旧 tag/release(已删)+ 推 v1.2.24-1-beta-tauri 触发新 CI。
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
What
把 Beta 版本号从 `1.2.24-beta.1` 改成 `1.2.24-1`。
Why — Tauri MSI 的 prerelease 限制
上次推 `v1.2.24-beta.1-beta-tauri` tag 触发的 CI run 25501471895 在 Windows job 报:
```
failed to bundle project: optional pre-release identifier in app version
must be numeric-only and cannot be greater than 65535 for msi target
```
Tauri MSI bundler 比 npm/Cargo 更严:prerelease 段必须是单一纯数字且 ≤ 65535。`beta.1` 含字母 + 多段,直接 reject。macOS DMG / Linux AppImage/deb/rpm 没这个限制,所以那 3 个平台 build 成功,只有 Windows 失败。
`1.2.24-1` 满足约束:
已做的清理
Diff
5 个文件 6 处版本号同步:`package.json`、`package-lock.json` (root + nested)、`tauri.conf.json`、`Cargo.toml`、`Cargo.lock`。CI 用的同一段 `Verify version sync` 本地实测 `OK 全部一致`。`cargo check` 干净。
Next
合并后我会立刻推 `v1.2.24-1-beta-tauri` tag,4 平台预期全部 success。
PR Type
Bug fix
Description
Replace version
1.2.24-beta.1with1.2.24-1across three config filesEnsure prerelease identifier is numeric-only for Tauri MSI bundler
Fix Windows MSI build failure caused by non-numeric prerelease
Diagram Walkthrough
File Walkthrough
package.json
Bump version in package.jsonopenless-all/app/package.json
1.2.24-beta.1to1.2.24-1Cargo.toml
Bump version in Cargo manifestopenless-all/app/src-tauri/Cargo.toml
1.2.24-beta.1to1.2.24-1tauri.conf.json
Bump version in Tauri configurationopenless-all/app/src-tauri/tauri.conf.json
1.2.24-beta.1to1.2.24-1