修复 Overview IPC 加载失败时误显示空数据#342
Merged
H-Chris233 merged 1 commit intoMay 8, 2026
Merged
Conversation
Overview previously treated rejected history and credential IPC calls like empty data, which made backend read failures indistinguishable from a clean first run. The page now keeps separate error flags, shows provider status as unreadable when credential status cannot load, and replaces history-derived metrics/recent rows with retryable inline failure states. Constraint: Issue Open-Less#311 asks for per-card inline feedback without changing backend handler signatures or adding global toast UI.\nRejected: Global error boundary or toast | broader UI behavior than needed for the Overview failure path.\nConfidence: high\nScope-risk: narrow\nTested: cd openless-all/app && git diff --check && npm run build\nNot-tested: Live Tauri IPC failure injection.\nRelated: Open-Less#311
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
摘要
修复 Overview 页在
listHistory()/getCredentials()IPC 调用失败时静默吞掉错误的问题。Closes #311
验证
git diff --checkcd openless-all/app && npm run buildPR Type
Bug fix, Enhancement
Description
Catch errors from listHistory and getCredentials IPC calls
ProviderCard now shows 'error' status distinct from not-configured
Metrics and recent area display inline error with retry button
Add error-related i18n strings in 5 locales
Diagram Walkthrough
File Walkthrough
Overview.tsx
Handle IPC errors with inline feedback and retryopenless-all/app/src/pages/Overview.tsx
en.ts
Add English error-related overview stringsopenless-all/app/src/i18n/en.ts
recentLoadFailed, historyRetry
ja.ts
Add Japanese error-related overview stringsopenless-all/app/src/i18n/ja.ts
recentLoadFailed, historyRetry
ko.ts
Add Korean error-related overview stringsopenless-all/app/src/i18n/ko.ts
recentLoadFailed, historyRetry
zh-CN.ts
Add Simplified Chinese error-related overview stringsopenless-all/app/src/i18n/zh-CN.ts
recentLoadFailed, historyRetry
zh-TW.ts
Add Traditional Chinese error-related overview stringsopenless-all/app/src/i18n/zh-TW.ts
recentLoadFailed, historyRetry