Skip to content

恢复“feat(ui):本地捆绑Noto Sans JP + UI字体选择器与系统字体”#368

Merged
appergb merged 1 commit into
betafrom
revert-364-feat/ui-font-picker-and-noto-sans-jp
May 8, 2026
Merged

恢复“feat(ui):本地捆绑Noto Sans JP + UI字体选择器与系统字体”#368
appergb merged 1 commit into
betafrom
revert-364-feat/ui-font-picker-and-noto-sans-jp

Conversation

@appergb
Copy link
Copy Markdown
Collaborator

@appergb appergb commented May 8, 2026

User description

Reverts #364


PR Type

Bug fix, Other


Description

  • Revert bundled font picker UI

  • Remove quiet mode settings controls

  • Restore remote Inter font cascade

  • Delete obsolete font helper files


Diagram Walkthrough

flowchart LR
  S["SettingsModal"] -- "remove UI controls" --> R["Reverted feature set"]
  M["main.tsx"] -- "drop font side effects" --> R
  T["tokens.css"] -- "restore default font stack" --> R
  F["fontFamily.ts / quietMode.ts"] -- "delete helpers" --> R
  I["i18n locales"] -- "remove labels" --> R
Loading

File Walkthrough

Relevant files
Dependencies
2 files
package.json
Remove bundled font dependencies                                                 
+0/-2     
main.tsx
Remove bundled font initialization                                             
+0/-10   
Bug fix
2 files
SettingsModal.tsx
Remove font and quiet controls                                                     
+0/-149 
tokens.css
Restore default font cascade                                                         
+5/-10   
Miscellaneous
7 files
en.ts
Remove reverted English settings strings                                 
+0/-52   
ja.ts
Remove reverted Japanese settings strings                               
+2/-54   
ko.ts
Remove reverted Korean settings strings                                   
+0/-52   
zh-CN.ts
Remove reverted Simplified Chinese strings                             
+0/-52   
zh-TW.ts
Remove reverted Traditional Chinese strings                           
+0/-52   
fontFamily.ts
Delete local font selection helper                                             
+0/-140 
quietMode.ts
Delete quiet mode storage helper                                                 
+0/-20   

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@appergb appergb merged commit 81990b3 into beta May 8, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

364 - Not compliant

Non-compliant requirements:

  • Bundle Noto Sans JP and Inter locally so the UI does not depend on Google Fonts.
  • Provide a UI font picker with presets, installed-font loading, custom font names, and persistence.
  • Apply the selected font at runtime through a CSS variable without rebuilding styles.
  • Prefer Noto Sans JP before Chinese CJK fallbacks so Japanese hosts do not render with Microsoft YaHei.
  • Add a quiet mode toggle that suppresses transient capsule labels while keeping errors visible.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Font fallback regression

Restoring the old font stack puts Microsoft YaHei ahead of any Japanese-specific face again, so Japanese UI text on Windows can fall back to Chinese glyph variants instead of the bundled JP font. This reintroduces the rendering bug that the original feature was fixing.

  /* Typography */
  --ol-font-sans: 'Inter', 'PingFang SC', 'Microsoft YaHei', -apple-system, BlinkMacSystemFont, 'Segoe UI', system-ui, sans-serif;
  --ol-font-mono: 'JetBrains Mono', 'SF Mono', 'Cascadia Code', 'Consolas', monospace;

  /* Status colors (sparse use only) */
  --ol-ok: #16a34a;
  --ol-ok-soft: #ecfdf5;
  --ol-warn: #d97706;
  --ol-warn-soft: #fff7ed;
  --ol-err: #dc2626;
}

* { box-sizing: border-box; }

body {
  margin: 0;
  font-family: var(--ol-font-sans);
Remote font dependency

The new Google Fonts @import makes the app dependent on an external stylesheet at runtime. In offline, air-gapped, or strict CSP environments, Inter will not load and the UI will silently fall back to system fonts.

@import url('https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&display=swap');

@appergb appergb deleted the revert-364-feat/ui-font-picker-and-noto-sans-jp branch May 8, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant