Improve capsule recording feedback#406
Closed
Michealmyson wants to merge 1 commit into
Closed
Conversation
PR Reviewer Guide 🔍(Review updated until commit 13c3474)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 13c3474 |
Collaborator
Collaborator
|
I've already modified the capsule logic in the new version, and I prefer typeless capsule processing logic, having changed it to the thinking and inclusion parts. So, I've received your PR, but I've decided to close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
This PR improves the dictation capsule feedback during recording and processing.
Changes:
Recording 00:08.insertingcapsule state before text insertion.Why
Previously the capsule mainly showed generic thinking/inserted feedback, so users could not tell whether the app was recording, transcribing, polishing, or inserting. This makes the voice input flow easier to understand and reduces the feeling that the app is stuck.
Verification
npm run buildsuccessfully.PR Type
Enhancement
Description
Show elapsed recording time
Add explicit inserting progress state
Clarify completion messages with counts
Update capsule translations and types
Diagram Walkthrough
File Walkthrough
9 files
Emit inserting state and richer completion textAdd inserting capsule state enum valueShow elapsed time and inserting statusAdd capsule progress strings in EnglishAdd capsule progress strings in JapaneseAdd capsule progress strings in KoreanAdd capsule progress strings in Simplified ChineseAdd capsule progress strings in Traditional ChineseExtend capsule state type with inserting