Package Windows beta feedback UI gates#494
Closed
Cooper-X-Oak wants to merge 1 commit into
Closed
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
Author
|
Closing per author request. I am pausing involvement with this project for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Parent
#478
Scope
This PR packages the low-conflict Windows beta feedback slices that can be reviewed independently of #490 / #492:
What changed
<select>controls and that SelectLite keeps expected keyboard / portal / accessibility behavior.Out of scope
coordinator.rsand should be packaged after Fix Windows hotkey conflicts, startup cancellation, and beta updater race #490 settles.needs-infountil the reporter provides environment and event-source details.Startingrepeated stop/cancel behavior, beta updater readiness probe, and Common Controls v6 manifest validation.Evidence
Issue evidence already posted during triage:
Validation
Run from
openless-all/app:Additional packaging gate:
git diff --checkAll passed locally.
npm run buildemitted only the existing Vite dynamic-import / chunk-size warnings.Cross-agent coordination
This branch was created in a separate worktree from #490's
fix/windows-handoff-corebranch. Scope gate confirmed this PR does not include #490-owned Rust/updater/startup files and does not include the #480 coordinator QA slice.PR Type
Bug fix, Enhancement, Tests
Description
Add Windows IME restore contracts
Mark main window opaque on Windows
Warn about Right Ctrl conflicts
Lock SelectLite and ASR behavior
Diagram Walkthrough
File Walkthrough
7 files
Add Right Ctrl warning translationsAdd Right Ctrl warning translationsAdd Right Ctrl warning translationsAdd Right Ctrl warning translationsAdd Right Ctrl warning translationsSet window kind and platform markersShow Right Ctrl conflict warning1 files
Use opaque Windows main canvas5 files
Validate local Qwen timeout contractValidate Windows IME restore lifecycleValidate opaque Windows main canvasValidate Right Ctrl warning policyValidate SelectLite and native select