fix(asr): allow HTTP endpoints with risk warning#550
Merged
H-Chris233 merged 1 commit intoMay 29, 2026
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
http://, noting API keys and audio content may leak in transit.Fixes #543
Verification
cargo test --manifest-path "openless-all/app/src-tauri/Cargo.toml" asr_transcriptions_url_accepts_base_or_transcriptions_endpointcargo test --manifest-path "openless-all/app/src-tauri/Cargo.toml" transcription_url_accepts_base_audio_or_full_endpointcargo check --manifest-path "openless-all/app/src-tauri/Cargo.toml"npm --prefix "openless-all/app" run buildgit diff --checkReview
PR Type
Bug fix, Enhancement
Description
Allow ASR HTTP endpoints
Remove HTTPS-only validation gate
Show insecure endpoint warning
Update localized warning copy
Diagram Walkthrough
File Walkthrough
1 files
Remove ASR HTTPS-only endpoint check6 files
Rewrite insecure endpoint warning textRewrite insecure endpoint warning textRewrite insecure endpoint warning textRewrite insecure endpoint warning textRewrite insecure endpoint warning textAdd insecure ASR endpoint warning