fix: sync preferences.json when switching ASR provider

[PINKIIILQWQ]

User description

Problem

Changing the ASR provider in Settings (e.g. from whisper to volcengine) calls set_active_asr_provider which only writes to the system Keychain, but does not update preferences.json. The preferences file update happens through a separate async path (updatePrefs → setSettings), creating a two-step save that can get out of sync.

If the second step fails (or if the app is restarted before it completes), preferences.json still has the old provider, and the user sees their setting "not saved".

Fix

set_active_asr_provider now also syncs the provider to preferences.json immediately after writing to Keychain, so both stores are always consistent regardless of what the frontend does.

if let Ok(mut prefs) = coord.read_settings() {
    prefs.active_asr_provider = provider.clone();
    let _ = coord.write_settings(prefs);
}

Test

1. Open Settings → change ASR provider
2. Kill and restart OpenLess
3. The selected provider persists correctly

---

PR Type

Bug fix

---

Description

• Sync ASR provider to preferences.json

• Sync LLM provider to preferences.json

• Warn when preference write fails

---

Diagram Walkthrough

flowchart LR
  A["set_active_asr_provider"] -- "write Keychain" --> B["preferences.json sync"]
  C["set_active_llm_provider"] -- "write Keychain" --> D["preferences.json sync"]

Loading

File Walkthrough

Relevant files

Bug fix

commands.rs Sync provider updates to settings file                                      openless-all/app/src-tauri/src/commands.rs After updating the ASR provider in CredentialsVault, also writes active_asr_provider into preferences.json. Changes set_active_llm_provider to accept CoordinatorState, then persists active_llm_provider to settings too. Logs a warning when syncing preferences.json fails, instead of failing the whole command. +19/-2

---

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 3c9612e)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Silent Failure If coord.write_settings fails here, the command still returns Ok(()). The UI will treat the provider change as saved even though preferences.json stays stale and the selection can revert after restart. if let Err(e) = coord.write_settings(prefs) { log::warn!("[set_active_asr_provider] sync preferences.json failed: {e}"); } Silent Failure The same error handling is used in the new LLM provider setter, so a preferences write failure is only logged. In that case the command reports success even though preferences.json was not updated, which can make the user's change appear saved until the next launch. if let Err(e) = coord.write_settings(prefs) { log::warn!("[set_active_llm_provider] sync preferences.json failed: {e}"); }

[github-actions]

Persistent review updated to latest commit 8e14d40

[github-actions]

Persistent review updated to latest commit 754acb9

[github-actions]

Persistent review updated to latest commit 3c9612e