show revision id in view and plot titles #2965
Conversation
|
|
||
| def confirm_action(confirmation_prompt): | ||
| def confirm_action(confirmation_prompt, assume_yes=False): | ||
| if assume_yes: |
There was a problem hiding this comment.
please separate this. You have this in a different PR.
| database_parser.add_argument("--add_all_to_all_operation", help="adds all users into all other operations", | ||
| action="store_true") | ||
|
|
||
| db_actions = database_parser.add_mutually_exclusive_group(required=True) |
There was a problem hiding this comment.
This is not part of the issue.
We split tasks and also PRs do handle only 1 issue.
|
@ReimarBauer i have removed the |
|
Please show the ID, this will always work, because a name can be shifted over IDs. If there is a name at an ID then show it too. The feature is interesting for those comparing images, it gives the possibility to see that there was a change. |
|
When I currently try it I can't see the result, have you a different image? 
|
|
While looking up the servers retrieved data I recognized that we don't have revision information yet implemented. So that is not an easy task. |
|
thanks for checking this and for the clarification. |
|
Please keep in mind that we only merge when a feature is completely integrated. Otherwise, someone during review might remove code that’s dead (incomplete). If you want to start working on the server-side code, begin with everything that uses ftml code. ftml is the default format for flighttracks and mscolab. Extend it so that it also works for flight tracks without mscolab. For example, There’s an example at |
|
thanks for the detailed guidance @ReimarBauer |
ReimarBauer
left a comment
ReimarBauer
left a comment
There was a problem hiding this comment.
We are leaving the pull request open for further updates, which will be posted here. Therefore, I am requesting changes.
|
@ReimarBauer i have now fully implemented revision support at the FTML level |
| raise SyntaxError(f"Invalid flight track filename: {name}") | ||
|
|
||
| def get_filename(self): | ||
| return self.filename |
|
@ReimarBauer can you please specify what should be changed in tests? |
When you remove a function you can likly also see by a test that it was needed too ;) Which model have you used for support? |
|
@ReimarBauer can you help me out regarding this? |
|
@ReimarBauer it would be really helpful if you could help me out! |
|
Please give me a hint what I should look at. |
aman-coder03
force-pushed
the
feature/show-revision-in-views
branch
from
ac7b556 to
79562d4
Compare
aman-coder03
force-pushed
the
feature/show-revision-in-views
branch
from
79562d4 to
8630a5c
Compare
|
the macos-15 test is getting passed but macos-14 test is not getting passed |
|
@ReimarBauer now all the tests are successful! |
Thx, I do soon. |
mslib/msui/flighttrack.py
Outdated
| self.lat, self.lon = locations[location] | ||
| else: | ||
| # Prefer explicitly provided coordinates (e.g., from server/XML) | ||
| if lat != 0.0 or lon != 0.0: |
There was a problem hiding this comment.
the tests fails for other reasons. When they get a timeout then an update of the data can not be done.
We should not have a test based solution which we don't have using the software.
the configured values should be the only truth to start here.
aman-coder03
force-pushed
the
feature/show-revision-in-views
branch
from
4cd6f8e to
d1b3f92
Compare
2 participants
summary
always show the revision ID in view window titles and plot titles.
if a revision name exists, it is appended.
motivation
improves traceability when switching revisions or comparing views.
Fixes #2026