refactor: Extract MSColab dialogs to separate modules #2993
+467
−387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @ReimarBauer , please have a look at this PR. Thanks! |
ReimarBauer
reviewed
Feb 9, 2026
|
|
||
| This file is part of MSS. | ||
|
|
||
| :copyright: Copyright 2019-2024 by the MSS team, see AUTHORS. |
Member
There was a problem hiding this comment.
please adjust the year to -2026
ReimarBauer
reviewed
Feb 9, 2026
|
|
||
| This file is part of MSS. | ||
|
|
||
| :copyright: Copyright 2019-2024 by the MSS team, see AUTHORS. |
Member
There was a problem hiding this comment.
please adjust the year to -2026
Member
|
We usually describe a task or project within an issue in our project, and then discuss it there. Once it's been assigned, we start working on it. I noticed you were interested in Google Summer of Code (GSoC). We won’t be taking part this year. |
ReimarBauer
requested changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
This PR refactors mslib/msui/mscolab.py to address the "God Class" maintainability issue. It extracts the MSColab_ConnectDialog and MSColab_OperationArchiveBrowser classes into their own dedicated modules (mslib/msui/mscolab_connect_dialog.py and mslib/msui/mscolab_archive_browser.py). This separation significantly reduces the size of mscolab.py and improves code organization without changing functionality.
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
python -m py_compile.Additional information for reviewer? :
This is part of a larger effort to improve the modularity of the MSColab client. By isolating UI components, we pave the way for better testability and future separation of network logic.
Does this PR results in some Documentation changes?
No
Checklist:
<type>: <subject>